-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update operation context for aggregation node #2798
Conversation
promptflow-core test result0 tests 0 ✅ 0s ⏱️ Results for commit 79f9b94. ♻️ This comment has been updated with latest results. |
promptflow SDK CLI Azure E2E Test Result dev/robbenwang_hide_aggregation 4 files 4 suites 4m 50s ⏱️ Results for commit 79f9b94. ♻️ This comment has been updated with latest results. |
SDK CLI Global Config Test Result dev/robbenwang_hide_aggregation4 tests 4 ✅ 1m 10s ⏱️ Results for commit 79f9b94. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result dev/robbenwang_hide_aggregation778 tests 778 ✅ 3m 42s ⏱️ Results for commit 79f9b94. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result dev/robbenwang_hide_aggregation238 tests 236 ✅ 6m 27s ⏱️ Results for commit 79f9b94. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result dev/robbenwang_hide_aggregation 4 files 4 suites 53m 14s ⏱️ Results for commit 79f9b94. ♻️ This comment has been updated with latest results. |
d3cfd0d
to
ae188ed
Compare
ae188ed
to
70937f7
Compare
70937f7
to
a9abd08
Compare
a9abd08
to
aaa8c34
Compare
497846e
to
1c2acab
Compare
Could you share more context of this PR. Why do we have to make this PR? What problem does it solve? |
For aggregate node, we ignore writing LineSummary. Add batch run id for aggregate node, to guarantee don't touch collection table.
1c2acab
to
62e90e3
Compare
When we run test case concurrently, test case may fail because of wrong operation context.
62e90e3
to
79f9b94
Compare
Description
LineSummary
. Then we could hide it from UX list. This is the motivation for this PR_exec_aggregation_with_bulk_results
method, used by nowhere.exec_aggregation
instead of_exec_aggregation
for better code structure.All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines