Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trace] Support list line runs with new session id #2801

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Apr 15, 2024

Description

Support session=<session> in PFS API /v1.0/LineRuns/list, so that UX can query those traces with specified session id.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

SDK CLI Global Config Test Result zhengfei/trace/list-trace-by-session-id

4 tests   4 ✅  1m 8s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 0e4f862.

Copy link

promptflow SDK CLI Azure E2E Test Result zhengfei/trace/list-trace-by-session-id

  4 files    4 suites   4m 52s ⏱️
219 tests 191 ✅  28 💤 0 ❌
876 runs  764 ✅ 112 💤 0 ❌

Results for commit 0e4f862.

Copy link

Executor Unit Test Result zhengfei/trace/list-trace-by-session-id

778 tests   778 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 0e4f862.

Copy link

Executor E2E Test Result zhengfei/trace/list-trace-by-session-id

238 tests   236 ✅  11m 8s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 0e4f862.

Copy link

SDK CLI Test Result zhengfei/trace/list-trace-by-session-id

    4 files      4 suites   54m 2s ⏱️
  595 tests   574 ✅ 21 💤 0 ❌
2 380 runs  2 296 ✅ 84 💤 0 ❌

Results for commit 0e4f862.

@zhengfeiwang zhengfeiwang merged commit 8d1b65a into main Apr 16, 2024
41 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/trace/list-trace-by-session-id branch April 16, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants