New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Refine connection usage #2802

Merged

brynn-code merged 2 commits into main from brynn/refine-connection-class

Apr 15, 2024

Contributor

brynn-code commented Apr 15, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.
Related: #2723

All Promptflow Contribution checklist:

The pull request does not introduce [breaking changes].
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.
Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.


          Refine connection usage

f05f137

Signed-off-by: Brynn Yin <[email protected]>

brynn-code requested a review from a team as a code owner

April 15, 2024 10:03

brynn-code temporarily deployed to internal

April 15, 2024 10:03

— with

GitHub Actions Inactive

brynn-code temporarily deployed to internal

April 15, 2024 10:03

— with

GitHub Actions Inactive

brynn-code temporarily deployed to internal

April 15, 2024 10:03

— with

GitHub Actions Inactive

github-actions bot added promptflow-devkit promptflow-azure labels

github-actions bot commented Apr 15, 2024 •

edited

Loading

promptflow SDK CLI Azure E2E Test Result brynn/refine-connection-class

4 files 4 suites 4m 56s ⏱️
219 tests 191 ✅ 28 💤 0 ❌
876 runs 764 ✅ 112 💤 0 ❌

Results for commit 2fb455a.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 15, 2024 •

edited

Loading

SDK CLI Global Config Test Result brynn/refine-connection-class

4 tests 4 ✅ 1m 9s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 2fb455a.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 15, 2024 •

edited

Loading

Executor Unit Test Result brynn/refine-connection-class

778 tests 778 ✅ 3m 41s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 2fb455a.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 15, 2024 •

edited

Loading

Executor E2E Test Result brynn/refine-connection-class

238 tests 236 ✅ 7m 19s ⏱️
1 suites 2 💤
1 files 0 ❌

Results for commit 2fb455a.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 15, 2024 •

edited

Loading

SDK CLI Test Result brynn/refine-connection-class

4 files 4 suites 54m 23s ⏱️
594 tests 573 ✅ 21 💤 0 ❌
2 376 runs 2 292 ✅ 84 💤 0 ❌

Results for commit 2fb455a.

♻️ This comment has been updated with latest results.


          Add test to ensure legacy type meta work

2fb455a

Signed-off-by: Brynn Yin <[email protected]>

brynn-code temporarily deployed to internal

April 15, 2024 10:53

— with

GitHub Actions Inactive

brynn-code temporarily deployed to internal

April 15, 2024 10:53

— with

GitHub Actions Inactive

brynn-code temporarily deployed to internal

April 15, 2024 10:53

— with

GitHub Actions Inactive

github-actions bot added the promptflow-core label

crazygao approved these changes

View reviewed changes

github-actions bot commented Apr 15, 2024

promptflow-core test result

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 2fb455a.

wangchao1230 approved these changes

View reviewed changes

brynn-code merged commit 9f51888 into main

51 checks passed

brynn-code deleted the brynn/refine-connection-class branch

April 15, 2024 11:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

promptflow-azure promptflow-core promptflow-devkit