Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[promptflow-evals] Update a missing sample file for the model config change #2833

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Apr 16, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ninghu ninghu requested a review from a team as a code owner April 16, 2024 15:42
Copy link

github-actions bot commented Apr 16, 2024

promptflow-evals test result

12 files  12 suites   2m 11s ⏱️
 3 tests  2 ✅  1 💤 0 ❌
36 runs  24 ✅ 12 💤 0 ❌

Results for commit a166ee4.

♻️ This comment has been updated with latest results.

@ninghu ninghu merged commit 05154ee into main Apr 16, 2024
38 checks passed
@ninghu ninghu deleted the users/ninhu/model_config_followup branch April 16, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants