Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support cohere models in build_index() #2834

Merged
merged 11 commits into from
Apr 25, 2024
Merged

support cohere models in build_index() #2834

merged 11 commits into from
Apr 25, 2024

Conversation

jingyizhu99
Copy link
Member

@jingyizhu99 jingyizhu99 commented Apr 16, 2024 •
edited by Jackxu9946
Loading

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@jingyizhu99 jingyizhu99 requested a review from a team as a code owner April 16, 2024 17:20
@jingyizhu99 jingyizhu99 requested a review from a team as a code owner April 16, 2024 21:11
liangjason87
liangjason87 previously approved these changes Apr 24, 2024
View reviewed changes
liangjason87
liangjason87 previously approved these changes Apr 24, 2024
View reviewed changes
liangjason87
liangjason87 previously approved these changes Apr 24, 2024
View reviewed changes
@hagh hagh self-requested a review April 24, 2024 19:45
@github-actions github-actions bot added the examples Improvements on examples label Apr 24, 2024
@jingyizhu99 jingyizhu99 force-pushed the users/jingyizhu/rag/build_index_with_cohere_models branch from 427ceb6 to f154fe1 Compare April 24, 2024 21:07
@github-actions github-actions bot removed the examples Improvements on examples label Apr 24, 2024
Jackxu9946
Jackxu9946 previously approved these changes Apr 24, 2024
View reviewed changes
liangjason87
liangjason87 previously approved these changes Apr 24, 2024
View reviewed changes
@jingyizhu99 jingyizhu99 dismissed stale reviews from liangjason87 and Jackxu9946 via 27be5c2 April 24, 2024 22:14
@jingyizhu99 jingyizhu99 merged commit 600c09e into main Apr 25, 2024
10 checks passed
@jingyizhu99 jingyizhu99 deleted the users/jingyizhu/rag/build_index_with_cohere_models branch April 25, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hagh hagh hagh approved these changes

@Jackxu9946 Jackxu9946 Jackxu9946 approved these changes

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@liangjason87 liangjason87 liangjason87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jingyizhu99 @hagh @Jackxu9946 @wangchao1230 @liangjason87