-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ModelConfig type as a temporary solution. #2836
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigiw
previously approved these changes
Apr 17, 2024
nagkumar91
previously approved these changes
Apr 17, 2024
ninghu
reviewed
Apr 17, 2024
src/promptflow-evals/promptflow/evals/evaluators/coherence/flow.flex.yaml
Outdated
Show resolved
Hide resolved
wangchao1230
previously approved these changes
Apr 17, 2024
wangchao1230
changed the title
Remove ModelConfig tyoe as a temporary solution.
Remove ModelConfig type as a temporary solution.
Apr 17, 2024
ninghu
reviewed
Apr 17, 2024
promptflow-evals test result 12 files 12 suites 2m 9s ⏱️ Results for commit 22e02a0. ♻️ This comment has been updated with latest results. |
…irovins/fix_types
nick863
dismissed stale reviews from wangchao1230, nagkumar91, and luigiw
via
April 17, 2024 17:39
5c71695
ninghu
approved these changes
Apr 17, 2024
luigiw
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we are removing types from the evaluator constructors as a temporary solution, before AzureOpenAIModelConfiguration type in the evaluator constructor will be officially supported.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines