Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ModelConfig type as a temporary solution. #2836

Merged
merged 7 commits into from
Apr 17, 2024
Merged

Conversation

nick863
Copy link
Contributor

@nick863 nick863 commented Apr 17, 2024

Description

In this PR we are removing types from the evaluator constructors as a temporary solution, before AzureOpenAIModelConfiguration type in the evaluator constructor will be officially supported.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nick863 nick863 requested a review from a team as a code owner April 17, 2024 00:56
luigiw
luigiw previously approved these changes Apr 17, 2024
nagkumar91
nagkumar91 previously approved these changes Apr 17, 2024
wangchao1230
wangchao1230 previously approved these changes Apr 17, 2024
@wangchao1230 wangchao1230 changed the title Remove ModelConfig tyoe as a temporary solution. Remove ModelConfig type as a temporary solution. Apr 17, 2024
Copy link

github-actions bot commented Apr 17, 2024

promptflow-evals test result

 12 files   12 suites   2m 9s ⏱️
 30 tests  30 ✅ 0 💤 0 ❌
360 runs  360 ✅ 0 💤 0 ❌

Results for commit 22e02a0.

♻️ This comment has been updated with latest results.

@nick863 nick863 dismissed stale reviews from wangchao1230, nagkumar91, and luigiw via 5c71695 April 17, 2024 17:39
@luigiw luigiw merged commit 8f043ed into main Apr 17, 2024
38 checks passed
@luigiw luigiw deleted the nirovins/fix_types branch April 17, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants