Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo that causes error in pytest collection #2839

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Fix typo that causes error in pytest collection #2839

merged 2 commits into from
Apr 18, 2024

Conversation

guming-learning
Copy link
Contributor

@guming-learning guming-learning commented Apr 17, 2024 •
edited
Loading

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@guming-learning guming-learning requested a review from a team as a code owner April 17, 2024 04:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

SDK CLI Global Config Test Result migu/fix-typo

4 tests   4 ✅  1m 12s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 2004f8c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result migu/fix-typo

  4 files    4 suites   4m 59s ⏱️
220 tests 192 ✅  28 💤 0 ❌
880 runs  768 ✅ 112 💤 0 ❌

Results for commit 2004f8c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

Executor Unit Test Result migu/fix-typo

778 tests   778 ✅  3m 42s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 2004f8c.

♻️ This comment has been updated with latest results.

@guming-learning guming-learning requested review from a team as code owners April 17, 2024 04:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

promptflow-evals test result

 12 files   12 suites   1m 12s ⏱️
 18 tests  18 ✅ 0 💤 0 ❌
216 runs  216 ✅ 0 💤 0 ❌

Results for commit 2004f8c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Executor E2E Test Result migu/fix-typo

238 tests   236 ✅  7m 13s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 2004f8c.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

SDK CLI Test Result migu/fix-typo

    4 files      4 suites   53m 5s ⏱️
  598 tests   577 ✅ 21 💤 0 ❌
2 392 runs  2 308 ✅ 84 💤 0 ❌

Results for commit 2004f8c.

♻️ This comment has been updated with latest results.

@guming-learning guming-learning merged commit 7d9c985 into main Apr 18, 2024
69 checks passed
@guming-learning guming-learning deleted the migu/fix-typo branch April 18, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

@DaweiCai DaweiCai DaweiCai approved these changes

Assignees
No one assigned
Labels
promptflow promptflow-evals promptflow-tools promptflow tools code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guming-learning @DaweiCai @zhengfeiwang @wangchao1230 @ToughAnyway