Sample for release 1.10.0 #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangchao1230
commented
Apr 18, 2024
7 tasks
wangchao1230
commented
Apr 18, 2024
# Description Please add an informative description that covers that changes made by the pull request and link all relevant issues. This pull request includes changes to the `examples/flex-flows/basic/flex-flow-quickstart-azure.ipynb`, `examples/flex-flows/basic/flex-flow-quickstart.ipynb`, `examples/flex-flows/eval-code-quality/README.md`, `examples/flex-flows/eval-code-quality/code_quality.py`, `examples/flex-flows/eval-code-quality/flow.flex.yaml`, and `examples/flex-flows/eval-code-quality/requirements.txt` files. The changes mainly involve the transition from function-based to class-based code evaluation, the introduction of model configuration objects, and updates to the setup instructions in the README file. Changes to the `examples/flex-flows/basic/flex-flow-quickstart-azure.ipynb` and `examples/flex-flows/basic/flex-flow-quickstart.ipynb` files: * Added a new cell to set up model configuration with connection or environment variables. [[1]](diffhunk://#diff-a64451050396d58812e8c2bbbce2f98b3b7e4e2a586be8c703487f8846741488R176-R199) [[2]](diffhunk://#diff-d4c67b6bed1a770d020db92e64df3bb319b132289e09dd083707e87ced5c577cR142-R175) * Updated the `eval_run` function call to include the `model_config` in the `init` parameter. [[1]](diffhunk://#diff-a64451050396d58812e8c2bbbce2f98b3b7e4e2a586be8c703487f8846741488R218) [[2]](diffhunk://#diff-d4c67b6bed1a770d020db92e64df3bb319b132289e09dd083707e87ced5c577cR293) * Updated the `eval_code` function to `CodeEvaluator` class and updated the evaluation call accordingly. Changes to the `examples/flex-flows/eval-code-quality/README.md` file: * Updated the description of the flow and the setup instructions to reflect the transition from function-based to class-based code evaluation and the introduction of model configuration objects. [[1]](diffhunk://#diff-0fa5117b09b5922685950440b10bdaeca4b206e05853c7472fff77545662bb15L2-R2) [[2]](diffhunk://#diff-0fa5117b09b5922685950440b10bdaeca4b206e05853c7472fff77545662bb15L15-R32) Changes to the `examples/flex-flows/eval-code-quality/code_quality.py` file: * Updated the `eval_code` function to the `CodeEvaluator` class, which uses a model configuration object to evaluate the quality of code snippets. [[1]](diffhunk://#diff-99b22c88ac4a230afbae6ec816390e8209fbe3d8e28cb9b87b00e0d832fd393bL32-R42) [[2]](diffhunk://#diff-99b22c88ac4a230afbae6ec816390e8209fbe3d8e28cb9b87b00e0d832fd393bL46-R90) Changes to the `examples/flex-flows/eval-code-quality/flow.flex.yaml` and `examples/flex-flows/eval-code-quality/requirements.txt` files: * Updated the `entry` field to use the `CodeEvaluator` class instead of the `eval_code` function. * Updated the requirements to use a specific version of the `promptflow` package. # All Promptflow Contribution checklist: - [ ] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes.
wangchao1230
commented
Apr 22, 2024
…ptflow into clwan/sample_1_10
# Description Please add an informative description that covers that changes made by the pull request and link all relevant issues. # All Promptflow Contribution checklist: - [ ] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes.
wangchao1230
commented
Apr 26, 2024
wangchao1230
commented
Apr 26, 2024
Stephen1993
previously approved these changes
Apr 26, 2024
0mza987
previously approved these changes
Apr 26, 2024
elliotzh
previously approved these changes
Apr 26, 2024
0mza987
previously approved these changes
Apr 26, 2024
elliotzh
reviewed
Apr 26, 2024
This reverts commit 13aaa8c.
elliotzh
previously approved these changes
Apr 26, 2024
0mza987
previously approved these changes
Apr 26, 2024
elliotzh
previously approved these changes
Apr 26, 2024
0mza987
previously approved these changes
Apr 26, 2024
0mza987
approved these changes
Apr 26, 2024
elliotzh
approved these changes
Apr 26, 2024
crazygao
pushed a commit
that referenced
this pull request
May 6, 2024
Target changes: - Flex flow: - basic chat notebook sample update: init with ModelConfiguration, aggregate - chat stream sample - Prompty: - Prmpty format sample: text, json, all, stream - [ ] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). - [ ] Pull request includes test coverage for the included changes. --------- Co-authored-by: Clement Wang <[email protected]> Co-authored-by: Han Wang <[email protected]> Co-authored-by: Han Wang <[email protected]> Co-authored-by: zhen <[email protected]> Co-authored-by: Ying Chen <[email protected]> Co-authored-by: zhangxingzhi <[email protected]> Co-authored-by: Honglin Du <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Target changes:
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines