Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the versions.txt and add the comment to pyproject.toml. #2913

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

nick863
Copy link
Contributor

@nick863 nick863 commented Apr 20, 2024

Description

We set the version of promptflow evals according to release parameter of the release pipeline. version.txt is not needed anymore. I also have added the comment to pyproject.toml file.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nick863 nick863 requested a review from a team as a code owner April 20, 2024 00:52
Copy link

github-actions bot commented Apr 20, 2024

promptflow-evals test result

 12 files   12 suites   1m 13s ⏱️
 30 tests  30 ✅ 0 💤 0 ❌
360 runs  360 ✅ 0 💤 0 ❌

Results for commit 3e998d2.

♻️ This comment has been updated with latest results.

@nick863 nick863 merged commit 63fafe4 into main Apr 22, 2024
39 checks passed
@nick863 nick863 deleted the nirovins/pipeline_eval_fixes branch April 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants