[Executor] Support applying default value and ensuring type for flex flow #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
promptflow SDK CLI Azure E2E Test Result dev/linatang/support_default_value 4 files 4 suites 4m 6s ⏱️ Results for commit e0ffe49. ♻️ This comment has been updated with latest results. |
SDK CLI Global Config Test Result dev/linatang/support_default_value6 tests 6 ✅ 1m 20s ⏱️ Results for commit e0ffe49. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result dev/linatang/support_default_value792 tests 792 ✅ 3m 43s ⏱️ Results for commit e0ffe49. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result dev/linatang/support_default_value242 tests 237 ✅ 5m 9s ⏱️ Results for commit e0ffe49. ♻️ This comment has been updated with latest results. |
lumoslnt
force-pushed
the
dev/linatang/support_default_value
branch
from
d5cc9c0 to
319351e
Compare
SDK CLI Test Result dev/linatang/support_default_value 4 files 4 suites 59m 14s ⏱️ Results for commit e0ffe49. ♻️ This comment has been updated with latest results. |
lumoslnt
force-pushed
the
dev/linatang/support_default_value
branch
from
319351e to
dd5b83b
Compare
added 2 commits
April 22, 2024 18:17
…om/microsoft/promptflow into dev/linatang/support_default_value
thy09
reviewed
Apr 26, 2024
added 4 commits
April 26, 2024 17:06
D-W-
approved these changes
Apr 28, 2024
thy09
approved these changes
Apr 29, 2024
crazygao
pushed a commit
that referenced
this pull request
May 6, 2024
…flow (#2923) # Description In this PR, we support applying default value and ensuring type provided for flex flow. If the input is not provided then we will apply the default value defined in the yaml, also we will check whether the input type is consistent with the type defined in yaml. An example yaml file: ``` entry: my_flow:MyClass init: input_init: type: string default: input_init inputs: input_1: type: string input_2: type: string default: input_2 ``` # All Promptflow Contribution checklist: - [x] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [x] Title of the pull request is clear and informative. - [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. --------- Co-authored-by: Lina Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we support applying default value and ensuring type provided for flex flow. If the input is not provided then we will apply the default value defined in the yaml, also we will check whether the input type is consistent with the type defined in yaml. An example yaml file:
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines