Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chat UI debug service #2927

Merged
merged 7 commits into from
May 14, 2024
Merged

Conversation

elliotzh
Copy link
Member

@elliotzh elliotzh commented Apr 22, 2024

Description

This PR is targeting to change the experience of Chat UI.

Previously, running pf flow test --ui will generate an url only, which means:

  1. need to initialize executor for each request
  2. hard to track logs and tracebacks
  3. depends on multiple local pfs

Now we will start a monitor on flow directory, which will try to maintain a serve app align with latest flow directory:

  1. the serve app won't be restarted unless there are changes in flow definition or init parameters
  2. logs and tracebacks will be redirect to the main cli process
  3. Chat UI talk to serve app /score directly instead of calling local pfs for each request

image

Limitations:

  1. Signature change in flow definition require manual refresh to update settings tab in Chat UI
  2. pf flow serve doesn't support specifying flow file name for now, so give below error message if specified flow file is not picked.
    image

basic flex flow chat ui
image

basic prompty chat ui:
image

dag flow:
image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@elliotzh elliotzh requested review from a team as code owners April 22, 2024 09:04
Copy link

github-actions bot commented Apr 22, 2024

SDK CLI Test Result zhangxingzhi/flow-test-ui-lifecycle

    4 files      4 suites   1h 3m 48s ⏱️
  737 tests   694 ✅  43 💤 0 ❌
2 948 runs  2 776 ✅ 172 💤 0 ❌

Results for commit 35a41a2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 23, 2024

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 35a41a2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 23, 2024

promptflow SDK CLI Azure E2E Test Result zhangxingzhi/flow-test-ui-lifecycle

  4 files    4 suites   4m 12s ⏱️
243 tests 204 ✅  39 💤 0 ❌
972 runs  816 ✅ 156 💤 0 ❌

Results for commit 35a41a2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 23, 2024

SDK CLI Global Config Test Result zhangxingzhi/flow-test-ui-lifecycle

6 tests   6 ✅  1m 25s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 35a41a2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 23, 2024

Executor Unit Test Result zhangxingzhi/flow-test-ui-lifecycle

796 tests   796 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 35a41a2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 23, 2024

Executor E2E Test Result zhangxingzhi/flow-test-ui-lifecycle

245 tests   239 ✅  5m 2s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit 35a41a2.

♻️ This comment has been updated with latest results.

@elliotzh elliotzh force-pushed the zhangxingzhi/flow-test-ui-lifecycle branch from 6b0c560 to 75cd97c Compare April 24, 2024 06:14
@elliotzh elliotzh force-pushed the zhangxingzhi/flow-test-ui-lifecycle branch from 75cd97c to dcfa7af Compare April 24, 2024 08:39
@elliotzh elliotzh changed the title ci: enable azure tests feat: chat ui debug service Apr 24, 2024
@elliotzh elliotzh changed the title feat: chat ui debug service feat: chat ui blocking service Apr 24, 2024
@elliotzh elliotzh force-pushed the zhangxingzhi/flow-test-ui-lifecycle branch from dcfa7af to b835b4b Compare April 24, 2024 10:01
wangchao1230
wangchao1230 previously approved these changes May 14, 2024
@elliotzh elliotzh merged commit 0eaa86b into main May 14, 2024
51 checks passed
@elliotzh elliotzh deleted the zhangxingzhi/flow-test-ui-lifecycle branch May 14, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants