Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[promptflow-evals] Support using DefaultAzureCredential in e2e test pipeline #2936

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Apr 22, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 22, 2024

promptflow-evals test result

 12 files   12 suites   1h 16m 12s ⏱️
 12 tests  12 ✅ 0 💤 0 ❌
144 runs  144 ✅ 0 💤 0 ❌

Results for commit 8250170.

♻️ This comment has been updated with latest results.

@ninghu ninghu changed the title support DefaultAzureCredential [promptflow-evals] Support using DefaultAzureCredential in e2e test pipeline Apr 22, 2024
@ninghu ninghu marked this pull request as ready for review April 23, 2024 00:39
@ninghu ninghu requested a review from a team as a code owner April 23, 2024 00:39
@ninghu ninghu merged commit 97d9fe2 into main Apr 23, 2024
39 checks passed
@ninghu ninghu deleted the users/ninhu/e2e_test_credential branch April 23, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants