Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the evaluation of target function #2938

Merged
merged 25 commits into from
Apr 25, 2024
Merged

Conversation

nick863
Copy link
Contributor

@nick863 nick863 commented Apr 23, 2024

Description

Evaluate call accepts target parameter. This parameter is callable, which accepts parameters, named the same as columns in the data set and returns dictionary to augment the data or to provide the target value. In this PR we are enabling this functionality. See work item 2932191.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nick863 nick863 requested a review from a team as a code owner April 23, 2024 00:21
Copy link

github-actions bot commented Apr 23, 2024

promptflow-evals test result

 12 files   12 suites   6m 31s ⏱️
 36 tests  36 ✅ 0 💤 0 ❌
432 runs  432 ✅ 0 💤 0 ❌

Results for commit eab6a9d.

♻️ This comment has been updated with latest results.

@nick863 nick863 requested review from ninghu and singankit April 24, 2024 19:26
@nick863 nick863 requested a review from ninghu April 24, 2024 20:23
ninghu
ninghu previously approved these changes Apr 24, 2024
@singankit singankit merged commit 6014616 into main Apr 25, 2024
34 of 38 checks passed
@singankit singankit deleted the nirovins/add_chat_evaluation branch April 25, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants