Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception separately for each span #2965

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

huaiyan
Copy link
Contributor

@huaiyan huaiyan commented Apr 24, 2024

Description

  1. Handle exception separately for each span, we don't want failure of one span make the whole batch spans fail
  2. Change default value of latency to None. Current value is 0.0, which is misleading for UX rendering.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 24, 2024

promptflow SDK CLI Azure E2E Test Result dev/robbenwang_cloud_span_exception

  4 files    4 suites   5m 30s ⏱️
237 tests 203 ✅  34 💤 0 ❌
948 runs  812 ✅ 136 💤 0 ❌

Results for commit faa4b54.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 24, 2024

SDK CLI Global Config Test Result dev/robbenwang_cloud_span_exception

4 tests   4 ✅  1m 19s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit faa4b54.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 24, 2024

Executor Unit Test Result dev/robbenwang_cloud_span_exception

792 tests   792 ✅  3m 42s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit faa4b54.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 24, 2024

Executor E2E Test Result dev/robbenwang_cloud_span_exception

240 tests   235 ✅  5m 9s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit faa4b54.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 24, 2024

SDK CLI Test Result dev/robbenwang_cloud_span_exception

    4 files      4 suites   1h 0m 35s ⏱️
  661 tests   648 ✅ 13 💤 0 ❌
2 644 runs  2 592 ✅ 52 💤 0 ❌

Results for commit faa4b54.

♻️ This comment has been updated with latest results.

@huaiyan huaiyan force-pushed the dev/robbenwang_cloud_span_exception branch from 2e47e0f to faa4b54 Compare April 25, 2024 02:45
@huaiyan huaiyan merged commit 7725069 into main Apr 25, 2024
41 of 42 checks passed
@huaiyan huaiyan deleted the dev/robbenwang_cloud_span_exception branch April 25, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants