-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[trace][refactor] Move tracing related functions to a better place #2990
Conversation
promptflow SDK CLI Azure E2E Test Result zhengfei/refactor/tracing-utils 4 files 4 suites 5m 2s ⏱️ Results for commit dae9424. ♻️ This comment has been updated with latest results. |
SDK CLI Global Config Test Result zhengfei/refactor/tracing-utils4 tests 4 ✅ 1m 16s ⏱️ Results for commit dae9424. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result zhengfei/refactor/tracing-utils792 tests 792 ✅ 3m 43s ⏱️ Results for commit dae9424. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result zhengfei/refactor/tracing-utils241 tests 236 ✅ 5m 11s ⏱️ Results for commit dae9424. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result zhengfei/refactor/tracing-utils 4 files 4 suites 57m 41s ⏱️ Results for commit dae9424. ♻️ This comment has been updated with latest results. |
Description
Move tracing related functions
promptflow._sdk._tracing
: tracing related function import place, with unit tests covered and guardedpromptflow-tracing
:start_trace_with_devkit
,setup_exporter_to_pfs
process_otlp_trace_request
- parse span from Protocol Bufferpromptflow._sdk._utils.tracing
: utilities for tracingRemove previous tracing utilities file
_tracing_utils.py
.Pass function that gets credential
For
process_otlp_trace_request
usage, user should pass the function that how to get credential, instead of the credential itself. However, as the environment may not have Azure extension, so we cannot directly passAzureCliCredential
in outside; so add a default logic inside the function.All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines