New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid generating flow.tools.json for python dag flow on pfazure run create #2997

Merged

elliotzh merged 3 commits into main from zhangxingzhi/avoid-gen-tool-meta-for-python-dag

Apr 25, 2024

Member

elliotzh commented Apr 25, 2024 •

edited

Loading

Description

customer should be able to submit a pfazure dag flow even if they don't have a local runtime with all requirements installed.

All Promptflow Contribution checklist:

The pull request does not introduce [breaking changes].
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.
Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.


          fix: avoid generating flow.tools.json for python dag flow on pfazure …

df4faf5

…run create

elliotzh requested review from a team as code owners

April 25, 2024 01:23

elliotzh temporarily deployed to internal

April 25, 2024 01:23

— with

GitHub Actions Inactive

elliotzh temporarily deployed to internal

April 25, 2024 01:23

— with

GitHub Actions Inactive

elliotzh temporarily deployed to internal

April 25, 2024 01:23

— with

GitHub Actions Inactive

github-actions bot added promptflow-devkit promptflow-azure labels

github-actions bot commented Apr 25, 2024 •

edited

Loading

promptflow SDK CLI Azure E2E Test Result zhangxingzhi/avoid-gen-tool-meta-for-python-dag

4 files 4 suites 5m 3s ⏱️
238 tests 203 ✅ 35 💤 0 ❌
952 runs 812 ✅ 140 💤 0 ❌

Results for commit e4d3604.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 25, 2024 •

edited

Loading

SDK CLI Global Config Test Result zhangxingzhi/avoid-gen-tool-meta-for-python-dag

4 tests 4 ✅ 1m 9s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit e4d3604.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 25, 2024 •

edited

Loading

Executor Unit Test Result zhangxingzhi/avoid-gen-tool-meta-for-python-dag

792 tests 792 ✅ 3m 42s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit e4d3604.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 25, 2024 •

edited

Loading

Executor E2E Test Result zhangxingzhi/avoid-gen-tool-meta-for-python-dag

241 tests 236 ✅ 5m 9s ⏱️
1 suites 5 💤
1 files 0 ❌

Results for commit e4d3604.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 25, 2024 •

edited

Loading

SDK CLI Test Result zhangxingzhi/avoid-gen-tool-meta-for-python-dag

4 files 4 suites 57m 44s ⏱️
661 tests 648 ✅ 13 💤 0 ❌
2 644 runs 2 592 ✅ 52 💤 0 ❌

Results for commit e4d3604.

♻️ This comment has been updated with latest results.


          fix: log warning only if meta generated for csharp flow

elliotzh temporarily deployed to internal

April 25, 2024 01:58

— with

GitHub Actions Inactive

elliotzh temporarily deployed to internal

April 25, 2024 01:58

— with

GitHub Actions Inactive

elliotzh temporarily deployed to internal

April 25, 2024 01:58

— with

GitHub Actions Inactive

wangchao1230 reviewed

View reviewed changes

src/promptflow-azure/tests/sdk_cli_azure_test/conftest.py Show resolved Hide resolved

PeiwenGaoMS reviewed

View reviewed changes

src/promptflow-devkit/promptflow/_proxy/_csharp_inspector_proxy.py Outdated Show resolved Hide resolved


          refactor: use cli sdk logger

e4d3604

elliotzh temporarily deployed to internal

April 25, 2024 05:01

— with

GitHub Actions Inactive

elliotzh temporarily deployed to internal

April 25, 2024 05:01

— with

GitHub Actions Inactive

elliotzh temporarily deployed to internal

April 25, 2024 05:01

— with

GitHub Actions Inactive

PeiwenGaoMS approved these changes

View reviewed changes

0mza987 reviewed

View reviewed changes

src/promptflow-azure/tests/sdk_cli_azure_test/e2etests/test_flow_operations.py Show resolved Hide resolved

elliotzh temporarily deployed to internal

April 25, 2024 08:25

— with

GitHub Actions Inactive

zhengfeiwang approved these changes

View reviewed changes

elliotzh merged commit 1c462b1 into main

41 of 42 checks passed

elliotzh deleted the zhangxingzhi/avoid-gen-tool-meta-for-python-dag branch

April 25, 2024 08:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

promptflow-azure promptflow-devkit