Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matrix, using recording even if it doesn't use it. #2999

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

crazygao
Copy link
Contributor

@crazygao crazygao commented Apr 25, 2024

Description

Fix matrix.

mac-latest is upgrade to 14, and currently doesn't support python < 3.10.

Fix some test issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

elliotzh
elliotzh previously approved these changes Apr 25, 2024
Copy link

github-actions bot commented Apr 25, 2024

promptflow SDK CLI Azure E2E Test Result yigao/matrix_another

  4 files    4 suites   5m 35s ⏱️
237 tests 203 ✅  34 💤 0 ❌
948 runs  812 ✅ 136 💤 0 ❌

Results for commit 53518a1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Global Config Test Result yigao/matrix_another

4 tests   4 ✅  1m 16s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 53518a1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Test Result yigao/matrix_another

    4 files      4 suites   1h 1m 16s ⏱️
  663 tests   650 ✅ 13 💤 0 ❌
2 652 runs  2 600 ✅ 52 💤 0 ❌

Results for commit 53518a1.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

promptflow-tracing test result

 12 files   12 suites   14s ⏱️
 58 tests  58 ✅ 0 💤 0 ❌
696 runs  696 ✅ 0 💤 0 ❌

Results for commit 53518a1.

♻️ This comment has been updated with latest results.

0mza987
0mza987 previously approved these changes Apr 25, 2024
Copy link

github-actions bot commented Apr 25, 2024

promptflow-evals test result

 12 files   12 suites   1h 46m 9s ⏱️
 13 tests  13 ✅ 0 💤 0 ❌
156 runs  156 ✅ 0 💤 0 ❌

Results for commit 53518a1.

♻️ This comment has been updated with latest results.

@elliotzh elliotzh merged commit 108e067 into main Apr 25, 2024
134 of 162 checks passed
@elliotzh elliotzh deleted the yigao/matrix_another branch April 25, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants