Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record root span name for each child span #3000

Closed
wants to merge 1 commit into from

Conversation

huaiyan
Copy link
Contributor

@huaiyan huaiyan commented Apr 25, 2024

Description

We will create placeholder for root span when the process is running.
It's very necessary to show root span name in the running placeholder.
So, we add root span name to the attributes of all child spans and use it to create placeholder
image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 25, 2024

promptflow SDK CLI Azure E2E Test Result dev/robbenwang_root_span_name

  4 files    4 suites   4m 6s ⏱️
238 tests 203 ✅  35 💤 0 ❌
952 runs  812 ✅ 140 💤 0 ❌

Results for commit d0ff2dd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Global Config Test Result dev/robbenwang_root_span_name

6 tests   6 ✅  1m 19s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit d0ff2dd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

Executor E2E Test Result dev/robbenwang_root_span_name

241 tests   236 ✅  5m 14s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit d0ff2dd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

Executor Unit Test Result dev/robbenwang_root_span_name

792 tests   792 ✅  3m 43s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit d0ff2dd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Test Result dev/robbenwang_root_span_name

    4 files      4 suites   58m 3s ⏱️
  663 tests   650 ✅ 13 💤 0 ❌
2 652 runs  2 600 ✅ 52 💤 0 ❌

Results for commit d0ff2dd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 26, 2024

promptflow-tracing test result

 12 files   12 suites   7m 54s ⏱️
 19 tests  19 ✅ 0 💤 0 ❌
228 runs  228 ✅ 0 💤 0 ❌

Results for commit d0ff2dd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 26, 2024

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit d0ff2dd.

♻️ This comment has been updated with latest results.

@huaiyan huaiyan force-pushed the dev/robbenwang_root_span_name branch from 68097cb to d0ff2dd Compare April 26, 2024 09:10
@huaiyan huaiyan changed the title WIP Record root span name for each child span Record root span name for each child span Apr 26, 2024
Copy link

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label May 10, 2024
Copy link

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-recent-activity There has been no recent activity on this issue/pull request promptflow-azure promptflow-core promptflow-tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant