-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix unintended parsing tool calls #3001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16oeahr
force-pushed
the
user/yalu4/fix_tool_call_condition
branch
from
April 25, 2024 08:45
32b1a86
to
03d52ac
Compare
16oeahr
force-pushed
the
user/yalu4/fix_tool_call_condition
branch
from
April 25, 2024 08:47
03d52ac
to
79fefa0
Compare
16oeahr
force-pushed
the
user/yalu4/fix_tool_call_condition
branch
from
April 25, 2024 09:08
79fefa0
to
1c88c1d
Compare
16oeahr
changed the title
[BugFix] Fix error message cut and unintended parsing tool calls
[BugFix] Fix unintended parsing tool calls
Apr 25, 2024
DaweiCai
previously approved these changes
Apr 25, 2024
chjinche
previously approved these changes
Apr 25, 2024
dorisjoy
previously approved these changes
Apr 25, 2024
DaweiCai
approved these changes
Apr 26, 2024
chjinche
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix unintended parsing tool calls
Error: Use GPT Function Calling-04-25-2024-12-19-14 - Azure AI | Machine Learning Studio
Same experiment run success after fix:
https://ml.azure.com/prompts/flow/f8925d22-478a-4b5c-8e16-a85158d03b9b/cd75a85c-33d5-4348-8e8c-ed6fc392c3b4/details?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourceGroups/promptflow/providers/Microsoft.MachineLearningServices/workspaces/promptflow-eastus-dev&tid=72f988bf-86f1-41af-91ab-2d7cd011db47
Run tool sample with fix:
https://ml.azure.com/prompts/flow/f8925d22-478a-4b5c-8e16-a85158d03b9b/3e2c30b8-d41e-4114-adb3-0f180fcbc6fe/details?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/providers/Microsoft.MachineLearningServices/workspaces/promptflow-eastus-dev&flight=pfnewllm,pfflowleveltool&tid=72f988bf-86f1-41af-91ab-2d7cd011db47
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines