Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix unintended parsing tool calls #3001

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

16oeahr
Copy link
Contributor

@16oeahr 16oeahr commented Apr 25, 2024

Description

Fix unintended parsing tool calls

Error: Use GPT Function Calling-04-25-2024-12-19-14 - Azure AI | Machine Learning Studio
image

Same experiment run success after fix:
https://ml.azure.com/prompts/flow/f8925d22-478a-4b5c-8e16-a85158d03b9b/cd75a85c-33d5-4348-8e8c-ed6fc392c3b4/details?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourceGroups/promptflow/providers/Microsoft.MachineLearningServices/workspaces/promptflow-eastus-dev&tid=72f988bf-86f1-41af-91ab-2d7cd011db47

Run tool sample with fix:
https://ml.azure.com/prompts/flow/f8925d22-478a-4b5c-8e16-a85158d03b9b/3e2c30b8-d41e-4114-adb3-0f180fcbc6fe/details?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/providers/Microsoft.MachineLearningServices/workspaces/promptflow-eastus-dev&flight=pfnewllm,pfflowleveltool&tid=72f988bf-86f1-41af-91ab-2d7cd011db47

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@16oeahr 16oeahr requested a review from a team as a code owner April 25, 2024 06:15
@github-actions github-actions bot added the promptflow-tools promptflow tools code label Apr 25, 2024
@16oeahr 16oeahr force-pushed the user/yalu4/fix_tool_call_condition branch from 32b1a86 to 03d52ac Compare April 25, 2024 08:45
@16oeahr 16oeahr force-pushed the user/yalu4/fix_tool_call_condition branch from 03d52ac to 79fefa0 Compare April 25, 2024 08:47
@16oeahr 16oeahr force-pushed the user/yalu4/fix_tool_call_condition branch from 79fefa0 to 1c88c1d Compare April 25, 2024 09:08
@16oeahr 16oeahr changed the title [BugFix] Fix error message cut and unintended parsing tool calls [BugFix] Fix unintended parsing tool calls Apr 25, 2024
DaweiCai
DaweiCai previously approved these changes Apr 25, 2024
chjinche
chjinche previously approved these changes Apr 25, 2024
dorisjoy
dorisjoy previously approved these changes Apr 25, 2024
@16oeahr 16oeahr dismissed stale reviews from dorisjoy and chjinche via bb1bf31 April 25, 2024 12:38
@16oeahr 16oeahr merged commit 7c1ac2f into main Apr 26, 2024
12 checks passed
@16oeahr 16oeahr deleted the user/yalu4/fix_tool_call_condition branch April 26, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
promptflow-tools promptflow tools code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants