[Executor] Support passing connection provider to script executor #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promptflow SDK CLI Azure E2E Test Result dev/linatang/support-connection-provider-in-script-executor 4 files 4 suites 4m 7s ⏱️ Results for commit 0b007f2. ♻️ This comment has been updated with latest results. |
promptflow-core test result0 tests 0 ✅ 0s ⏱️ Results for commit 0b007f2. ♻️ This comment has been updated with latest results. |
SDK CLI Global Config Test Result dev/linatang/support-connection-provider-in-script-executor6 tests 6 ✅ 1m 22s ⏱️ Results for commit 0b007f2. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result dev/linatang/support-connection-provider-in-script-executor792 tests 792 ✅ 3m 44s ⏱️ Results for commit 0b007f2. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result dev/linatang/support-connection-provider-in-script-executor242 tests 237 ✅ 5m 12s ⏱️ Results for commit 0b007f2. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result dev/linatang/support-connection-provider-in-script-executor 4 files 4 suites 59m 7s ⏱️ Results for commit 0b007f2. ♻️ This comment has been updated with latest results. |
lumoslnt
changed the title
lumoslnt
changed the title
thy09
reviewed
Apr 26, 2024
lumoslnt
force-pushed
the
dev/linatang/support-connection-provider-in-script-executor
branch
from
976ae5b to
9abfbe0
Compare
lumoslnt
force-pushed
the
dev/linatang/support-connection-provider-in-script-executor
branch
from
9abfbe0 to
1169daf
Compare
thy09
previously approved these changes
Apr 29, 2024
thy09
approved these changes
Apr 30, 2024
brynn-code
approved these changes
Apr 30, 2024
lumoslnt
deleted the
dev/linatang/support-connection-provider-in-script-executor
branch
crazygao
pushed a commit
that referenced
this pull request
May 6, 2024
) # Description Currently we use `ConnectionProvider.get_instance` to get connections in script executor, and it doesn't support passing connections to it directly, while the flow executor can accept connections, which is inconsistent. For flow serving, we want the behaviors to be consistent to refine the conenction resolving logic, so in this PR, we support directly passing connections to script executor. # All Promptflow Contribution checklist: - [x] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [x] Title of the pull request is clear and informative. - [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. Co-authored-by: Lina Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we use
ConnectionProvider.get_instanceto get connections in script executor, and it doesn't support passing connections to it directly, while the flow executor can accept connections, which is inconsistent. For flow serving, we want the behaviors to be consistent to refine the conenction resolving logic, so in this PR, we support directly passing connections to script executor.All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines