Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: extra string at the beginning of yaml in snapshot #3006

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

elliotzh
Copy link
Member

@elliotzh elliotzh commented Apr 25, 2024

Description

Fix a bug that !!omap tag will generated at the beginning of flow.flex.yaml in snapshot and break local to cloud

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 25, 2024

promptflow SDK CLI Azure E2E Test Result dev/hotfix-flex-flow-yaml-issue

  4 files    4 suites   5m 0s ⏱️
238 tests 203 ✅  35 💤 0 ❌
952 runs  812 ✅ 140 💤 0 ❌

Results for commit f9d9f3d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f9d9f3d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Global Config Test Result dev/hotfix-flex-flow-yaml-issue

5 tests   5 ✅  1m 9s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit f9d9f3d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

Executor Unit Test Result dev/hotfix-flex-flow-yaml-issue

792 tests   792 ✅  3m 41s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit f9d9f3d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

Executor E2E Test Result dev/hotfix-flex-flow-yaml-issue

241 tests   236 ✅  5m 12s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit f9d9f3d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Test Result dev/hotfix-flex-flow-yaml-issue

    4 files      4 suites   57m 36s ⏱️
  663 tests   650 ✅ 13 💤 0 ❌
2 652 runs  2 600 ✅ 52 💤 0 ❌

Results for commit f9d9f3d.

♻️ This comment has been updated with latest results.

wangchao1230
wangchao1230 previously approved these changes Apr 25, 2024
@elliotzh elliotzh merged commit 40c054d into main Apr 25, 2024
52 checks passed
@elliotzh elliotzh deleted the dev/hotfix-flex-flow-yaml-issue branch April 25, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants