Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Support parsing chat prompt if role property has \r around colon #3007

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

chjinche
Copy link
Contributor

Description

Issue:

UX may add extra '\r' to user input, which may throw confusing error to user because user does not write '\r' explicitly.

  • user input
    image

  • ux adding extra '\r'
    image

  • confusing error
    image

Solution:

Handling '\r' around role property colon. The same way as '\r' around role colon.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the promptflow-tools promptflow tools code label Apr 25, 2024
@chjinche chjinche marked this pull request as ready for review April 25, 2024 08:39
@chjinche chjinche requested a review from a team as a code owner April 25, 2024 08:39
16oeahr
16oeahr previously approved these changes Apr 25, 2024
@chjinche chjinche merged commit b4c9f37 into main Apr 25, 2024
12 checks passed
@chjinche chjinche deleted the chjinche/role_property_parsing branch April 25, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
promptflow-tools promptflow tools code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants