Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Executor] Refine exec line in script executor #3009

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

lumoslnt
Copy link
Contributor

Description

Refine exec line in script executor.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 25, 2024

promptflow SDK CLI Azure E2E Test Result dev/linatang/refine-exec-line-in-script-executor

  4 files    4 suites   4m 58s ⏱️
238 tests 203 ✅  35 💤 0 ❌
952 runs  812 ✅ 140 💤 0 ❌

Results for commit 28ff50e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 28ff50e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Global Config Test Result dev/linatang/refine-exec-line-in-script-executor

5 tests   5 ✅  1m 11s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 28ff50e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

Executor Unit Test Result dev/linatang/refine-exec-line-in-script-executor

792 tests   792 ✅  3m 44s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 28ff50e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

Executor E2E Test Result dev/linatang/refine-exec-line-in-script-executor

241 tests   236 ✅  5m 13s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit 28ff50e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Test Result dev/linatang/refine-exec-line-in-script-executor

    4 files      4 suites   57m 58s ⏱️
  663 tests   650 ✅ 13 💤 0 ❌
2 652 runs  2 600 ✅ 52 💤 0 ❌

Results for commit 28ff50e.

♻️ This comment has been updated with latest results.

@lumoslnt lumoslnt force-pushed the dev/linatang/refine-exec-line-in-script-executor branch from d39d220 to 3510a29 Compare April 25, 2024 10:02
@lumoslnt lumoslnt changed the title [Do not review] Refine exec line in script executor [Executor] Refine exec line in script executor Apr 25, 2024
thy09
thy09 previously approved these changes Apr 25, 2024
@thy09
Copy link
Contributor

thy09 commented Apr 25, 2024

Add more detailed description for this change.

@lumoslnt lumoslnt merged commit 86a812d into main Apr 26, 2024
52 checks passed
@lumoslnt lumoslnt deleted the dev/linatang/refine-exec-line-in-script-executor branch April 26, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants