Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PICKME] Fix prompty with workspace connection #3011

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

brynn-code
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Signed-off-by: Brynn Yin <[email protected]>
Copy link

promptflow SDK CLI Azure E2E Test Result brynn/fix-prompty-with-workspace-connection

  4 files    4 suites   4m 59s ⏱️
238 tests 203 ✅  35 💤 0 ❌
952 runs  812 ✅ 140 💤 0 ❌

Results for commit 833ae4d.

Copy link

SDK CLI Global Config Test Result brynn/fix-prompty-with-workspace-connection

5 tests   5 ✅  1m 13s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 833ae4d.

Copy link

Executor Unit Test Result brynn/fix-prompty-with-workspace-connection

792 tests   792 ✅  3m 41s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 833ae4d.

Copy link

Executor E2E Test Result brynn/fix-prompty-with-workspace-connection

241 tests   236 ✅  5m 12s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit 833ae4d.

@brynn-code brynn-code changed the title Fix prompty with workspace connection [PICKME] Fix prompty with workspace connection Apr 25, 2024
Copy link

SDK CLI Test Result brynn/fix-prompty-with-workspace-connection

    4 files      4 suites   56m 21s ⏱️
  663 tests   650 ✅ 13 💤 0 ❌
2 652 runs  2 600 ✅ 52 💤 0 ❌

Results for commit 833ae4d.

@brynn-code brynn-code merged commit 4c00cdb into main Apr 25, 2024
42 checks passed
@brynn-code brynn-code deleted the brynn/fix-prompty-with-workspace-connection branch April 25, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants