Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connection] Support flexflow with connection config #3012

Merged
merged 10 commits into from
Apr 26, 2024

Conversation

brynn-code
Copy link
Contributor

@brynn-code brynn-code commented Apr 25, 2024

Description

  • Change connection provider config key to "PF_CONNECTION_PROVIDER" to align with serving existing one.
  • Refine connection provider behavior: Let dict connection provider raise error when not found, related executor logic changed.
  • Set env var in pfclient, to support flex flow with global config.
  • Let default azure credential exclude interactive browser: to avoid unexpected hang up when getting connection inside executor sub process.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 25, 2024

promptflow SDK CLI Azure E2E Test Result brynn/refine-connection-provider-usage

  4 files    4 suites   5m 5s ⏱️
238 tests 203 ✅  35 💤 0 ❌
952 runs  812 ✅ 140 💤 0 ❌

Results for commit e856bcb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Global Config Test Result brynn/refine-connection-provider-usage

6 tests   6 ✅  1m 14s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit e856bcb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e856bcb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

Executor Unit Test Result brynn/refine-connection-provider-usage

792 tests   792 ✅  3m 43s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit e856bcb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

Executor E2E Test Result brynn/refine-connection-provider-usage

241 tests   236 ✅  5m 13s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit e856bcb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Test Result brynn/refine-connection-provider-usage

    4 files      4 suites   58m 12s ⏱️
  663 tests   650 ✅ 13 💤 0 ❌
2 652 runs  2 600 ✅ 52 💤 0 ❌

Results for commit e856bcb.

♻️ This comment has been updated with latest results.

Signed-off-by: Brynn Yin <[email protected]>
Signed-off-by: Brynn Yin <[email protected]>
Signed-off-by: Brynn Yin <[email protected]>
@brynn-code brynn-code changed the title Support flexflow with global config [Connection] Support flexflow with global config Apr 26, 2024
@brynn-code brynn-code changed the title [Connection] Support flexflow with global config [Connection] Support flexflow with connection config Apr 26, 2024
lumoslnt
lumoslnt previously approved these changes Apr 26, 2024
wxpjimmy
wxpjimmy previously approved these changes Apr 26, 2024
Signed-off-by: Brynn Yin <[email protected]>
Signed-off-by: Brynn Yin <[email protected]>
@brynn-code brynn-code merged commit 198e890 into main Apr 26, 2024
52 checks passed
@brynn-code brynn-code deleted the brynn/refine-connection-provider-usage branch April 26, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants