New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix missing otel_trace_id in FlowRunInfo.otel_trace_id #3013

Merged

riddlexu merged 5 commits into main from users/yangtongxu/fixTraceId

Apr 26, 2024

Contributor

riddlexu commented Apr 25, 2024 •

edited

Loading

Description

Currently, the otel_trace_id is not assigned in FlowRunInfo.deserialize. In multi-container scenarios, the otel_trace_id will be missing.

All Promptflow Contribution checklist:

The pull request does not introduce [breaking changes].
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.
Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.


          [Bugfix] Fix missing otel_trace_id in FlowRunInfo.otel_trace_id

7eb9dd4

riddlexu requested a review from a team as a code owner

April 25, 2024 09:45

riddlexu temporarily deployed to internal

April 25, 2024 09:45

— with

GitHub Actions Inactive

riddlexu temporarily deployed to internal

April 25, 2024 09:45

— with

GitHub Actions Inactive

riddlexu temporarily deployed to internal

April 25, 2024 09:45

— with

GitHub Actions Inactive

github-actions bot added the promptflow-core label

fix

riddlexu requested a review from a team as a code owner

April 25, 2024 09:47

riddlexu temporarily deployed to internal

April 25, 2024 09:47

— with

GitHub Actions Inactive

riddlexu temporarily deployed to internal

April 25, 2024 09:47

— with

GitHub Actions Inactive

riddlexu temporarily deployed to internal

April 25, 2024 09:47

— with

GitHub Actions Inactive

github-actions bot added the promptflow label

huaiyan approved these changes

View reviewed changes

riddlexu requested a review from thy09

April 25, 2024 09:49

github-actions bot commented Apr 25, 2024 •

edited

Loading

promptflow SDK CLI Azure E2E Test Result users/yangtongxu/fixTraceId

4 files 4 suites 5m 0s ⏱️
238 tests 203 ✅ 35 💤 0 ❌
952 runs 812 ✅ 140 💤 0 ❌

Results for commit a69edec.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 25, 2024 •

edited

Loading

promptflow-core test result

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit a69edec.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 25, 2024 •

edited

Loading

SDK CLI Global Config Test Result users/yangtongxu/fixTraceId

5 tests 5 ✅ 1m 20s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit a69edec.

♻️ This comment has been updated with latest results.

thy09 approved these changes

View reviewed changes

github-actions bot commented Apr 25, 2024 •

edited

Loading

Executor Unit Test Result users/yangtongxu/fixTraceId

792 tests 792 ✅ 3m 43s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit a69edec.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 25, 2024 •

edited

Loading

Executor E2E Test Result users/yangtongxu/fixTraceId

241 tests 236 ✅ 5m 10s ⏱️
1 suites 5 💤
1 files 0 ❌

Results for commit a69edec.

♻️ This comment has been updated with latest results.

github-actions bot commented Apr 25, 2024 •

edited

Loading

SDK CLI Test Result users/yangtongxu/fixTraceId

4 files 4 suites 58m 26s ⏱️
663 tests 650 ✅ 13 💤 0 ❌
2 652 runs 2 600 ✅ 52 💤 0 ❌

Results for commit a69edec.

♻️ This comment has been updated with latest results.


          Merge branch 'main' into users/yangtongxu/fixTraceId

1f6ed82

riddlexu temporarily deployed to internal

April 25, 2024 10:27

— with

GitHub Actions Inactive

riddlexu temporarily deployed to internal

April 25, 2024 10:27

— with

GitHub Actions Inactive

riddlexu temporarily deployed to internal

April 25, 2024 10:27

— with

GitHub Actions Inactive


          Merge branch 'main' into users/yangtongxu/fixTraceId

14f97b0

riddlexu temporarily deployed to internal

April 25, 2024 10:56

— with

GitHub Actions Inactive

riddlexu temporarily deployed to internal

April 25, 2024 10:56

— with

GitHub Actions Inactive

riddlexu temporarily deployed to internal

April 25, 2024 10:56

— with

GitHub Actions Inactive


          Merge branch 'main' into users/yangtongxu/fixTraceId

a69edec

riddlexu temporarily deployed to internal

April 25, 2024 12:16

— with

GitHub Actions Inactive

riddlexu temporarily deployed to internal

April 25, 2024 12:16

— with

GitHub Actions Inactive

riddlexu temporarily deployed to internal

April 25, 2024 12:16

— with

GitHub Actions Inactive

riddlexu requested a review from zhengfeiwang

April 26, 2024 03:03

zhengfeiwang approved these changes

View reviewed changes

riddlexu merged commit 5c510d5 into main

52 checks passed

riddlexu deleted the users/yangtongxu/fixTraceId branch

April 26, 2024 03:13

riddlexu requested a review from a team

April 26, 2024 05:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

promptflow promptflow-core