Fix test_retrieve_tool_func_result_error failure in python version >= 3.11 #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promptflow SDK CLI Azure E2E Test Result users/gega/fixUT 4 files 4 suites 5m 0s ⏱️ Results for commit 241cada. |
promptflow-core test result0 tests 0 ✅ 0s ⏱️ Results for commit 241cada. |
SDK CLI Global Config Test Result users/gega/fixUT5 tests 5 ✅ 1m 18s ⏱️ Results for commit 241cada. |
Executor Unit Test Result users/gega/fixUT792 tests 792 ✅ 3m 41s ⏱️ Results for commit 241cada. |
Executor E2E Test Result users/gega/fixUT241 tests 236 ✅ 5m 12s ⏱️ Results for commit 241cada. |
SDK CLI Test Result users/gega/fixUT 4 files 4 suites 58m 22s ⏱️ Results for commit 241cada. |
crazygao
approved these changes
Apr 25, 2024
thy09
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this test will fail in python version >= 3.11, the reason is because:
So the error message in python version >= 3.11 will be:
'Unable to retrieve tool func result due to 'ToolFuncCallScenario ToolFuncCallScenario.REVERSE_GENERATED_BY response must be a dict. {"index_type": "Azure Cognitive Search", "index": "index_1"} is not a dict.'. \nPlease contact the tool author/support team for troubleshooting assistance.'
But in the python version < 3.11, the error message will be:
'Unable to retrieve tool func result due to 'ToolFuncCallScenario reverse_generated_by response must be a dict. {"index_type": "Azure Cognitive Search", "index": "index_1"} is not a dict.'. \nPlease contact the tool author/support team for troubleshooting assistance.'
In order to keep the test stable in different python environment, so change the error message from:
f"ToolFuncCallScenario {func_call_scenario} response must be a dict. " f"{result} is not a dict."
to
f"ToolFuncCallScenario {func_call_scenario.value} response must be a dict. " f"{result} is not a dict."