Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: csharp executor proxy ci failure #3018

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

elliotzh
Copy link
Member

@elliotzh elliotzh commented Apr 25, 2024

Description

fix 2 test on Windows:
promptflow-devkit/tests/sdk_cli_test/e2etests/test_csharp_sdk.py

  • test_destroy_with_terminates_gracefully
  • test_destroy_with_force_kill

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@elliotzh elliotzh force-pushed the zhangxingzhi/fix-csharp-executor-proxy-ci-failure branch from b74cf62 to 9b4076a Compare April 25, 2024 10:43
@elliotzh elliotzh requested a review from a team as a code owner April 25, 2024 10:43
Copy link

github-actions bot commented Apr 25, 2024

promptflow SDK CLI Azure E2E Test Result zhangxingzhi/fix-csharp-executor-proxy-ci-failure

  4 files    4 suites   4m 58s ⏱️
238 tests 203 ✅  35 💤 0 ❌
952 runs  812 ✅ 140 💤 0 ❌

Results for commit 4502f19.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Global Config Test Result zhangxingzhi/fix-csharp-executor-proxy-ci-failure

5 tests   5 ✅  1m 13s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 4502f19.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

Executor Unit Test Result zhangxingzhi/fix-csharp-executor-proxy-ci-failure

792 tests   792 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 4502f19.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

Executor E2E Test Result zhangxingzhi/fix-csharp-executor-proxy-ci-failure

241 tests   236 ✅  5m 9s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit 4502f19.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 25, 2024

SDK CLI Test Result zhangxingzhi/fix-csharp-executor-proxy-ci-failure

    4 files      4 suites   56m 59s ⏱️
  663 tests   650 ✅ 13 💤 0 ❌
2 652 runs  2 600 ✅ 52 💤 0 ❌

Results for commit 4502f19.

♻️ This comment has been updated with latest results.

@elliotzh elliotzh force-pushed the zhangxingzhi/fix-csharp-executor-proxy-ci-failure branch from e89b729 to 4502f19 Compare April 25, 2024 11:22
@elliotzh elliotzh merged commit 935176f into main Apr 25, 2024
40 checks passed
@elliotzh elliotzh deleted the zhangxingzhi/fix-csharp-executor-proxy-ci-failure branch April 25, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants