Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support flow.flex.yaml for csharp serve #3019

Merged
merged 5 commits into from
Apr 26, 2024
Merged

feat: support flow.flex.yaml for csharp serve #3019

merged 5 commits into from
Apr 26, 2024

Conversation

elliotzh
Copy link
Member

@elliotzh elliotzh commented Apr 25, 2024 •
edited
Loading

Description

Allow run pf flow serve on below csharp scenario

  1. flex flow, including class init
  2. use yaml as source

Add an util function to infer language of a flow

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@elliotzh elliotzh requested a review from a team as a code owner April 25, 2024 11:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result zhangxingzhi/support-flex-flow-serve-for-csharp

  4 files    4 suites   4m 58s ⏱️
238 tests 203 ✅  35 💤 0 ❌
952 runs  812 ✅ 140 💤 0 ❌

Results for commit 0f9a1a5.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0410afb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

SDK CLI Global Config Test Result zhangxingzhi/support-flex-flow-serve-for-csharp

5 tests   5 ✅  1m 12s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 0f9a1a5.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

Executor Unit Test Result zhangxingzhi/support-flex-flow-serve-for-csharp

792 tests   792 ✅  3m 43s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 0f9a1a5.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

Executor E2E Test Result zhangxingzhi/support-flex-flow-serve-for-csharp

241 tests   236 ✅  5m 10s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit 0f9a1a5.

♻️ This comment has been updated with latest results.

@elliotzh elliotzh requested a review from a team as a code owner April 25, 2024 11:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

SDK CLI Test Result zhangxingzhi/support-flex-flow-serve-for-csharp

    4 files      4 suites   57m 46s ⏱️
  663 tests   650 ✅ 13 💤 0 ❌
2 652 runs  2 600 ✅ 52 💤 0 ❌

Results for commit 0f9a1a5.

♻️ This comment has been updated with latest results.

@elliotzh elliotzh force-pushed the zhangxingzhi/support-flex-flow-serve-for-csharp branch from 0410afb to e59a390 Compare April 26, 2024 01:50
@elliotzh elliotzh force-pushed the zhangxingzhi/support-flex-flow-serve-for-csharp branch from e59a390 to 24c538a Compare April 26, 2024 01:52
@elliotzh elliotzh force-pushed the zhangxingzhi/support-flex-flow-serve-for-csharp branch from 24c538a to ac0027c Compare April 26, 2024 01:57
@elliotzh elliotzh changed the title feat: support flow.flex.yaml for csharp feat: support flow.flex.yaml for csharp serve Apr 26, 2024
@elliotzh elliotzh force-pushed the zhangxingzhi/support-flex-flow-serve-for-csharp branch from ac0027c to 98c38f7 Compare April 26, 2024 02:34
wangchao1230
wangchao1230 previously approved these changes Apr 26, 2024
View reviewed changes
lalala123123
lalala123123 previously approved these changes Apr 26, 2024
View reviewed changes
@elliotzh elliotzh dismissed stale reviews from lalala123123 and wangchao1230 via 0f9a1a5 April 26, 2024 02:59
@elliotzh elliotzh merged commit 98d3e69 into main Apr 26, 2024
42 checks passed
@elliotzh elliotzh deleted the zhangxingzhi/support-flex-flow-serve-for-csharp branch April 26, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@lalala123123 lalala123123 lalala123123 approved these changes

@thy09 thy09 thy09 approved these changes

Assignees
No one assigned
Labels
promptflow-devkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elliotzh @thy09 @lalala123123 @wangchao1230