Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine the error/message for run_tracker.py #329

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

chw-microsoft
Copy link
Contributor

@chw-microsoft chw-microsoft commented Sep 7, 2023

Description

Update the error message at run_tracker.py, to make it more concise and actionable

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@chw-microsoft chw-microsoft requested a review from a team as a code owner September 7, 2023 05:34
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Executor Unit Test Result chw/pf/run_tracker_error

    2 files      2 suites   36s ⏱️
161 tests 161 ✔️ 0 💤 0
322 runs  321 ✔️ 1 💤 0

Results for commit 0a916f1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
10908 8304 76% 40% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/promptflow/promptflow/_core/_errors.py 93% 🟢
src/promptflow/promptflow/_core/run_tracker.py 83% 🟢
TOTAL 88% 🟢

updated for commit: 0a916f1 by action🐍

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Executor E2E Test Result chw/pf/run_tracker_error

    2 files      2 suites   6m 23s ⏱️
  92 tests   90 ✔️ 2 💤 0
184 runs  178 ✔️ 6 💤 0

Results for commit 0a916f1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

SDK CLI Test Result chw/pf/run_tracker_error

    2 files      2 suites   19m 11s ⏱️
207 tests 194 ✔️ 13 💤 0
414 runs  388 ✔️ 26 💤 0

Results for commit 0a916f1.

♻️ This comment has been updated with latest results.

src/promptflow/promptflow/_core/run_tracker.py Outdated Show resolved Hide resolved
src/promptflow/promptflow/_core/run_tracker.py Outdated Show resolved Hide resolved
src/promptflow/promptflow/_core/run_tracker.py Outdated Show resolved Hide resolved
src/promptflow/promptflow/_core/run_tracker.py Outdated Show resolved Hide resolved
src/promptflow/promptflow/_core/_errors.py Outdated Show resolved Hide resolved
src/promptflow/promptflow/_core/_errors.py Outdated Show resolved Hide resolved
zzn2
zzn2 previously approved these changes Sep 8, 2023
@chw-microsoft chw-microsoft merged commit e8b7fc3 into main Sep 13, 2023
18 checks passed
@chw-microsoft chw-microsoft deleted the chw/pf/run_tracker_error branch September 13, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants