-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AAD credential to support storage account with disabling account key #3367
Merged
YingChen1996
merged 13 commits into
main
from
dev/chenyin/update_credential_without_secret
Jun 7, 2024
Merged
Support AAD credential to support storage account with disabling account key #3367
YingChen1996
merged 13 commits into
main
from
dev/chenyin/update_credential_without_secret
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promptflow SDK CLI Azure E2E Test Result dev/chenyin/update_credential_without_secret 4 files 4 suites 4m 15s ⏱️ Results for commit a949bac. ♻️ This comment has been updated with latest results. |
SDK CLI Global Config Test Result dev/chenyin/update_credential_without_secret6 tests 6 ✅ 1m 18s ⏱️ Results for commit a949bac. ♻️ This comment has been updated with latest results. |
wangchao1230
approved these changes
Jun 7, 2024
lalala123123
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
Samples failed when azure login: https://github.com/microsoft/promptflow/actions/runs/9406919010/job/25911489619
Offline discuss with @crazygao, it seems related with Powershell issues and suggest removing the "enable-AzPSSession: true"
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines