Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AAD credential to support storage account with disabling account key #3367

Merged
merged 13 commits into from
Jun 7, 2024

Conversation

YingChen1996
Copy link
Contributor

@YingChen1996 YingChen1996 commented Jun 3, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.
Samples failed when azure login: https://github.com/microsoft/promptflow/actions/runs/9406919010/job/25911489619
Offline discuss with @crazygao, it seems related with Powershell issues and suggest removing the "enable-AzPSSession: true"

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Jun 3, 2024

promptflow SDK CLI Azure E2E Test Result dev/chenyin/update_credential_without_secret

  4 files    4 suites   4m 15s ⏱️
243 tests 203 ✅  40 💤 0 ❌
972 runs  812 ✅ 160 💤 0 ❌

Results for commit a949bac.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 3, 2024

SDK CLI Global Config Test Result dev/chenyin/update_credential_without_secret

6 tests   6 ✅  1m 18s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit a949bac.

♻️ This comment has been updated with latest results.

@YingChen1996 YingChen1996 merged commit 96dbf33 into main Jun 7, 2024
87 checks passed
@YingChen1996 YingChen1996 deleted the dev/chenyin/update_credential_without_secret branch June 7, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants