Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PromptFlow] Move import to the head of the file to avoid package references. #349

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

Hhhilulu
Copy link
Contributor

@Hhhilulu Hhhilulu commented Sep 8, 2023

Description

Move import to the head of the file to avoid package references.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Hhhilulu Hhhilulu requested a review from a team as a code owner September 8, 2023 09:49
@Hhhilulu Hhhilulu changed the title move import to header [Promptflow] Move import to header Sep 8, 2023
@Hhhilulu Hhhilulu changed the title [Promptflow] Move import to header [PromptFlow] Move import to head of file Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Executor Unit Test Result luluzuo/move-import-to-header

    2 files      2 suites   44s ⏱️
161 tests 161 ✔️ 0 💤 0
322 runs  321 ✔️ 1 💤 0

Results for commit 7616695.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
10899 8301 76% 40% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/promptflow/promptflow/executor/_line_execution_process_pool.py 59% 🟢
TOTAL 59% 🟢

updated for commit: 7616695 by action🐍

@Hhhilulu Hhhilulu changed the title [PromptFlow] Move import to head of file [PromptFlow] Move import to the head of the file to avoid package references. Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Executor E2E Test Result luluzuo/move-import-to-header

    2 files      2 suites   6m 56s ⏱️
  91 tests   89 ✔️ 2 💤 0
182 runs  176 ✔️ 6 💤 0

Results for commit 7616695.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

SDK CLI Test Result luluzuo/move-import-to-header

    2 files      2 suites   17m 52s ⏱️
207 tests 195 ✔️ 12 💤 0
414 runs  390 ✔️ 24 💤 0

Results for commit 7616695.

@Hhhilulu Hhhilulu merged commit cd2291e into main Sep 8, 2023
@Hhhilulu Hhhilulu deleted the luluzuo/move-import-to-header branch September 8, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants