Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chat-with-pdf sample with doc change and code bug fixes #366

Closed
wants to merge 6 commits into from
Closed

Update chat-with-pdf sample with doc change and code bug fixes #366

wants to merge 6 commits into from

Conversation

ttthree
Copy link
Member

@ttthree ttthree commented Sep 11, 2023 •
edited
Loading

Description

Use gpt-3.5-turbo requires a change of mode/deployment name to switch between azure open ai and open ai, because gpt-3.5-turbo is not a valid deployment name in azure ...

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ttthree ttthree requested a review from a team as a code owner September 11, 2023 01:11
@github-actions github-actions bot added the examples Improvements on examples label Sep 11, 2023
@ttthree ttthree changed the title Use gpt-4 in chat-with-pdf to allow model/deployment consistency across aoai and oai Update chat-with-pdf sample with doc change and code bug fixes Sep 15, 2023
@ttthree ttthree closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisagreenview lisagreenview lisagreenview left review comments

Assignees
No one assigned
Labels
examples Improvements on examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttthree @lisagreenview