Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Promptflow SDK& CLI] docker build build is confusing #379

Merged
merged 4 commits into from
Sep 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/cloud/azureai/deploy-to-azure-appservice.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This example demos how to deploy [web-classification](https://github.com/microso
Use the command below to build a flow as docker format app:

```bash
pf flow build --source ../../flows/standard/web-classification --output build --format docker
pf flow build --source ../../flows/standard/web-classification --output dist --format docker
```

Note that all dependent connections must be created before building as docker.
Expand All @@ -27,7 +27,7 @@ The two scripts will do the following things:
:::{tab-item} Bash
Example command to use bash script:
```shell
bash deploy.sh --path build -i <image_tag> --name my_app_23d8m -r <docker registery> -g <resource_group>
bash deploy.sh --path dist -i <image_tag> --name my_app_23d8m -r <docker registery> -g <resource_group>
```
See the full parameters by `bash deploy.sh -h`.
:::
Expand Down
4 changes: 2 additions & 2 deletions docs/how-to-guides/deploy-a-flow/deploy-using-docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ refer to [Setup connection for web-classifiction](https://github.com/microsoft/p
Use the command below to build a flow as docker format app:

```bash
pf flow build --source ../../flows/standard/web-classification --output build --format docker
pf flow build --source ../../flows/standard/web-classification --output dist --format docker
YingChen1996 marked this conversation as resolved.
Show resolved Hide resolved
```

Note that all dependent connections must be created before exporting as docker.
Expand All @@ -65,7 +65,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image
Run the command below to build image:

```bash
docker build build -t web-classification-serve
docker build dist -t web-classification-serve
```

### Run Docker image
Expand Down
4 changes: 2 additions & 2 deletions examples/tutorials/e2e-development/chat-with-pdf.md
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ the other choices, please refer to [flow deploy docs](https://microsoft.github.i
Use the command below to build a flow as docker format app:

```bash
pf flow build --source . --output build --format docker
pf flow build --source . --output dist --format docker
```

### Deploy with Docker
Expand All @@ -321,7 +321,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image
Run the command below to build image:

```shell
docker build build -t chat-with-pdf-serve
docker build dist -t chat-with-pdf-serve
```

#### Run Docker image
Expand Down
4 changes: 2 additions & 2 deletions examples/tutorials/flow-deploy/azure-app-service/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pf connection create --file ../../../connections/azure_openai.yml --set api_key=
Use the command below to build a flow as docker format app:

```bash
pf flow build --source ../../../flows/standard/web-classification --output build --format docker
pf flow build --source ../../../flows/standard/web-classification --output dist --format docker
```


Expand All @@ -32,7 +32,7 @@ The two scripts will do the following things:

Example command to use bash script:
```shell
bash deploy.sh --path build -i <image_tag> --name my_app_23d8m -r <docker registery> -g <resource_group>
bash deploy.sh --path dist -i <image_tag> --name my_app_23d8m -r <docker registery> -g <resource_group>
```

Example command to use powershell script:
Expand Down
4 changes: 2 additions & 2 deletions examples/tutorials/flow-deploy/docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ pf connection create --file ../../../connections/azure_openai.yml --set api_key=
Use the command below to build a flow as docker format app:

```bash
pf flow build --source ../../../flows/standard/web-classification --output build --format docker
pf flow build --source ../../../flows/standard/web-classification --output dist --format docker
```

## Deploy with Docker
Expand All @@ -25,7 +25,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image
Run the command below to build image:

```shell
docker build build -t web-classification-serve
docker build dist -t web-classification-serve
```

### Run Docker image
Expand Down
4 changes: 2 additions & 2 deletions examples/tutorials/flow-deploy/kubernetes/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pf connection create --file ../../../connections/azure_openai.yml --set api_key=
Use the command below to build a flow as docker format app:

```bash
pf flow build --source ../../../flows/standard/web-classification --output build --format docker
pf flow build --source ../../../flows/standard/web-classification --output dist --format docker
```

## Deploy with Kubernetes
Expand All @@ -26,7 +26,7 @@ Like other Dockerfile, you need to build the image first. You can tag the image
Then run the command below:

```shell
cd build
cd dist
docker build . -t web-classification-serve
```

Expand Down