Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix key for FastapiContextDataProvider context data provider #3890

Closed
wants to merge 3 commits into from

Conversation

prise6
Copy link

@prise6 prise6 commented Dec 20, 2024

Description

Hello,
with v2 fastapi + managed online endpoint with AML, the data collector can't write anything because in FlowMonitor input_data are requested with input_data = self.context_data_provider.get_request_data(). This method looks for a key called input_data in FastapiContextDataProvider.
But the value of this key is None because we don't set it correctly in get_score_router() (see changes is PR).

Maybe i'm wrong ?

Copy link

github-actions bot commented Jan 3, 2025

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Jan 3, 2025
@prise6
Copy link
Author

prise6 commented Jan 4, 2025

Still an issue to fix. This PR shows how to fix it.

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue/pull request label Jan 4, 2025
@prise6
Copy link
Author

prise6 commented Jan 9, 2025

Is it possible to have a comment/look from a maintainer :) ?

Copy link

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Jan 24, 2025
@prise6
Copy link
Author

prise6 commented Jan 25, 2025

Still an issue. Take a look...

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue/pull request label Jan 25, 2025
Copy link

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Feb 20, 2025
Copy link

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external no-recent-activity There has been no recent activity on this issue/pull request promptflow-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant