Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New PF Tool: Open_Source_llm - Dev, Test, & Documentation #531

Merged
merged 36 commits into from
Sep 29, 2023
Merged

New PF Tool: Open_Source_llm - Dev, Test, & Documentation #531

merged 36 commits into from
Sep 29, 2023

Conversation

gjwoods
Copy link
Contributor

@gjwoods gjwoods commented Sep 18, 2023 •
edited
Loading

Description

The open_source_llm PromptFlow tool. This tool allows users to access their Online Endpoint deployment of the Falcon, LlaMa-2, Dolly, and GTP-2 models from the Azure Machine Learning Model Catalog. More models to

This PR includes the full functionality of the open_source_llm tool, along with quality assurance tests, documentation, and supporting common code.

Screenshots for the tools appearance in VsCode and local test pass results follow.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Screen Shot in VsCode

image

Tests

image

@gjwoods gjwoods requested a review from a team as a code owner September 18, 2023 00:50
@github-actions github-actions bot added documentation Improvements or additions to documentation promptflow-tools promptflow tools code labels Sep 18, 2023
@gjwoods gjwoods mentioned this pull request Sep 18, 2023
Closed
6 tasks
@gjwoods
Copy link
Contributor Author

gjwoods commented Sep 18, 2023

Todo:

  • Test in VsCode
  • Add Connection to tests

Bowen-Guo
Bowen-Guo reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@Bowen-Guo Bowen-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code does not have any unit tests or e2e tests. So it is prone to changes, including dependency package version upgrade.

Please add some tests.

chjinche
chjinche reviewed Sep 18, 2023
View reviewed changes
src/promptflow-tools/promptflow/tools/open_source_llm.py Outdated Show resolved Hide resolved
src/promptflow-tools/promptflow/tools/open_source_llm.py Outdated Show resolved Hide resolved
src/promptflow-tools/promptflow/tools/open_source_llm.py Outdated Show resolved Hide resolved
src/promptflow-tools/promptflow/tools/yamls/open_source_llm_with_custom_llm.yaml Outdated Show resolved Hide resolved
src/promptflow-tools/promptflow/tools/yamls/open_source_llm_with_custom_llm.yaml Outdated Show resolved Hide resolved
src/promptflow-tools/promptflow/tools/yamls/open_source_llm_with_custom_llm.yaml Outdated Show resolved Hide resolved
docs/reference/index.md Show resolved Hide resolved
docs/reference/tools-reference/open_source_llm-tool.md Outdated Show resolved Hide resolved
@gjwoods
Copy link
Contributor Author

gjwoods commented Sep 25, 2023

This code does not have any unit tests or e2e tests. So it is prone to changes, including dependency package version upgrade.

Please add some tests.

@gjwoods gjwoods closed this Sep 25, 2023
@gjwoods gjwoods reopened this Sep 25, 2023
thy09
thy09 previously approved these changes Sep 27, 2023
View reviewed changes
@chjinche
Copy link
Contributor

May change the title to be more specific and provide a PR description

@chjinche
Copy link
Contributor

some clues: serp api uts failure may be related to your change of skip_if_no_key. They are expected to be skipped.

@gjwoods gjwoods changed the title [Open_Source_llm] Initial Setup New PF Tool: Open_Source_llm - Dev, Test, & Documentation Sep 27, 2023
chjinche
chjinche previously approved these changes Sep 28, 2023
View reviewed changes
thy09
thy09 previously approved these changes Sep 28, 2023
View reviewed changes
@gjwoods gjwoods dismissed stale reviews from thy09 and chjinche via a108fd9 September 28, 2023 16:03
@chjinche chjinche merged commit e067bbe into microsoft:main Sep 29, 2023
7 checks passed
@gjwoods gjwoods deleted the users/gewoods/open_source_llm/initial branch December 11, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiazengcindy jiazengcindy jiazengcindy left review comments

@chenslucky chenslucky chenslucky left review comments

@Bowen-Guo Bowen-Guo Bowen-Guo left review comments

@prakharg-msft prakharg-msft prakharg-msft approved these changes

@chjinche chjinche chjinche approved these changes

@thy09 thy09 thy09 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation promptflow-tools promptflow tools code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gjwoods @chjinche @thy09 @Bowen-Guo @chenslucky @prakharg-msft @jiazengcindy