Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chat-with-pdf example failed #534

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Fix chat-with-pdf example failed #534

merged 5 commits into from
Sep 21, 2023

Conversation

lalala123123
Copy link
Contributor

@lalala123123 lalala123123 commented Sep 18, 2023 •
edited
Loading

Description

image

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the examples Improvements on examples label Sep 18, 2023
@lalala123123 lalala123123 marked this pull request as ready for review September 19, 2023 02:28
@lalala123123 lalala123123 requested a review from a team as a code owner September 19, 2023 02:28
@lalala123123 lalala123123 merged commit 18b35c4 into main Sep 21, 2023
15 of 18 checks passed
@lalala123123 lalala123123 deleted the zhrua/fix_chat_sample branch September 21, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

@D-W- D-W- D-W- approved these changes

Assignees
No one assigned
Labels
examples Improvements on examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lalala123123 @D-W- @zhengfeiwang