Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sample] Fix sample tests to align with latest executor change #572

Merged
merged 6 commits into from
Sep 26, 2023
Merged

[Sample] Fix sample tests to align with latest executor change #572

merged 6 commits into from
Sep 26, 2023

Conversation

D-W-
Copy link
Contributor

@D-W- D-W- commented Sep 20, 2023

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@D-W- D-W- requested a review from a team as a code owner September 20, 2023 02:59
@github-actions github-actions bot added the examples Improvements on examples label Sep 20, 2023
@D-W- D-W- temporarily deployed to internal September 20, 2023 03:05 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal September 20, 2023 03:05 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal September 20, 2023 03:05 — with GitHub Actions Inactive
@github-actions
Copy link

Executor Unit Test Result wanhan/fix_sample_tests

    2 files      2 suites   45s ⏱️
210 tests 210 ✔️ 0 💤 0 ❌
418 runs  417 ✔️ 1 💤 0 ❌

Results for commit 46ad08e.

@github-actions
Copy link

Executor E2E Test Result wanhan/fix_sample_tests

    2 files      2 suites   6m 31s ⏱️
  94 tests   92 ✔️ 2 💤 0 ❌
188 runs  182 ✔️ 6 💤 0 ❌

Results for commit 46ad08e.

0mza987
0mza987 previously approved these changes Sep 20, 2023
View reviewed changes
@github-actions
Copy link

SDK CLI Test Result wanhan/fix_sample_tests

    2 files      2 suites   13m 55s ⏱️
213 tests 202 ✔️ 10 💤 0 ❌ 1 🔥
426 runs  404 ✔️ 20 💤 0 ❌ 2 🔥

For more details on these errors, see this check.

Results for commit 46ad08e.

zhengfeiwang
zhengfeiwang previously approved these changes Sep 20, 2023
View reviewed changes
@D-W- D-W- dismissed stale reviews from zhengfeiwang and 0mza987 via 6aa43c5 September 20, 2023 09:17
elliotzh
elliotzh previously approved these changes Sep 21, 2023
View reviewed changes
@D-W- D-W- merged commit 686e0a8 into main Sep 26, 2023
18 checks passed
@D-W- D-W- deleted the wanhan/fix_sample_tests branch September 26, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 left review comments

@0mza987 0mza987 0mza987 approved these changes

@crazygao crazygao crazygao approved these changes

@zhengfeiwang zhengfeiwang zhengfeiwang left review comments

@elliotzh elliotzh elliotzh left review comments

Assignees
No one assigned
Labels
examples Improvements on examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@D-W- @crazygao @0mza987 @elliotzh @zhengfeiwang @wangchao1230