Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[custom tool] Provide guidance for configuring tool icon #616

Merged
merged 2 commits into from
Sep 28, 2023
Merged

[custom tool] Provide guidance for configuring tool icon #616

merged 2 commits into from
Sep 28, 2023

Conversation

jiazengcindy
Copy link
Contributor

@jiazengcindy jiazengcindy commented Sep 26, 2023 •
edited
Loading

Description

Provide guidance for configuring tool icon.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@jiazengcindy jiazengcindy requested a review from a team as a code owner September 26, 2023 06:40
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 06:40 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 06:40 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 06:40 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 06:40 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 06:40 — with GitHub Actions Inactive
@github-actions github-actions bot added documentation Improvements or additions to documentation promptflow-tools promptflow tools code fundamental labels Sep 26, 2023
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 06:43 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 06:43 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 06:43 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 06:43 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 06:43 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

SDK CLI Global Config Test Result jiazeng/tool_icon_doc

2 tests   2 ✔️  26s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit c1c3ed4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

Executor Unit Test Result jiazeng/tool_icon_doc

    2 files      2 suites   46s ⏱️
277 tests 276 ✔️ 1 💤 0 ❌
546 runs  543 ✔️ 3 💤 0 ❌

Results for commit c1c3ed4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

SDK PFS E2E Test Result jiazeng/tool_icon_doc

8 tests   8 ✔️  30s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit c1c3ed4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

Executor E2E Test Result jiazeng/tool_icon_doc

    2 files      2 suites   13m 2s ⏱️
102 tests 100 ✔️ 2 💤 0 ❌
204 runs  198 ✔️ 6 💤 0 ❌

Results for commit c1c3ed4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

SDK CLI Test Result jiazeng/tool_icon_doc

    2 files      2 suites   22m 57s ⏱️
269 tests 252 ✔️ 17 💤 0 ❌
538 runs  504 ✔️ 34 💤 0 ❌

Results for commit c1c3ed4.

♻️ This comment has been updated with latest results.

chjinche
chjinche reviewed Sep 26, 2023
View reviewed changes
docs/how-to-guides/index.md Outdated Show resolved Hide resolved
docs/how-to-guides/develop-custom-tool/use-tool-icon.md Outdated Show resolved Hide resolved
docs/how-to-guides/develop-custom-tool/index.md Outdated Show resolved Hide resolved
docs/how-to-guides/develop-custom-tool/use-tool-icon.md Outdated Show resolved Hide resolved
@jiazengcindy jiazengcindy changed the title [custom tool] Provide guidance for configuring tool icon and structure [custom tool] Provide guidance for configuring tool icon Sep 26, 2023
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 10:50 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 10:50 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 10:50 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 10:50 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 26, 2023 10:50 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:25 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:25 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:29 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:29 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:29 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:29 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:29 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:40 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:40 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:40 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:40 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:40 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:45 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:45 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:45 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:45 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 09:45 — with GitHub Actions Inactive
@jiazengcindy
update
fa3be4c 
change name

update

update

update

update

update

update doc

update

update

update
@jiazengcindy
rename
c1c3ed4 
update

update

update

update

update

update

update

update

update

update

update

update

update
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 10:14 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 10:14 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 10:14 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 10:14 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 10:14 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy temporarily deployed to internal September 28, 2023 10:30 — with GitHub Actions Inactive
@jiazengcindy jiazengcindy merged commit 037f627 into main Sep 28, 2023
@jiazengcindy jiazengcindy deleted the jiazeng/tool_icon_doc branch September 28, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chjinche chjinche chjinche approved these changes

@liuyuhang13 liuyuhang13 liuyuhang13 approved these changes

@16oeahr 16oeahr Awaiting requested review from 16oeahr

@DaweiCai DaweiCai Awaiting requested review from DaweiCai

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples Improvements on examples fundamental promptflow-tools promptflow tools code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiazengcindy @liuyuhang13 @chjinche