Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic-chat flow.dag file for online-endpoint deployment #667

Closed
wants to merge 1 commit into from

Conversation

ouphi
Copy link

@ouphi ouphi commented Sep 28, 2023

Description

Proposition to fix the issue #666

The problem is that when following this tutorial to deploy an online-endpoint from the basic-chat example the online-endpoint does not work well, we get an error as described in the according issue.
Adding the provider and the module fixed the issue for me.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ouphi ouphi requested a review from a team as a code owner September 28, 2023 21:06
@github-actions github-actions bot added the examples Improvements on examples label Sep 28, 2023
@ouphi ouphi force-pushed the fix-for-endpoint-deployment branch from 954c441 to 7b1eed6 Compare September 29, 2023 08:00
@ouphi ouphi force-pushed the fix-for-endpoint-deployment branch from 7b1eed6 to 19a63a8 Compare September 29, 2023 08:06
@ouphi
Copy link
Author

ouphi commented Oct 12, 2023

Closing this PR as the issue can be fixed in the example, by using a more recent promptflow image, as discussed in this issue #666

@ouphi ouphi closed this Oct 12, 2023
@ouphi ouphi deleted the fix-for-endpoint-deployment branch October 12, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Improvements on examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant