PF Recording/Replaying part for sdk_cli #719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK CLI Test Result yigao/recording_draft320 tests 308 ✔️ 23m 16s ⏱️ For more details on these failures, see this check. Results for commit d3b4c4a. ♻️ This comment has been updated with latest results. |
|
|
||
| def mock_bulkresult_get_openai_metrics(self): | ||
| # Some tests request the metrics in replay mode. | ||
| total_metrics = {"total_tokens": 0, "duration": 0} |
There was a problem hiding this comment.
why is this return a constant ?
There was a problem hiding this comment.
some of the tests are testing against these constants.
example:
There was a problem hiding this comment.
since our tool doesn't have a real llm connection, we need to mock these returns.
src/promptflow/tests/sdk_cli_test/recording_utilities/tool_record.py
Outdated
Show resolved
Hide resolved
src/promptflow/tests/sdk_cli_test/recording_utilities/tool_record.py
Outdated
Show resolved
Hide resolved
src/promptflow/tests/sdk_cli_test/recording_utilities/tool_record.py
Outdated
Show resolved
Hide resolved
src/promptflow/tests/test_configs/flows/web_classification/webClassification20.csv
Show resolved
Hide resolved
| result = {} | ||
| for n in connection_names: | ||
| try: | ||
| conn = client.connections.get(name=n, with_secrets=True) |
There was a problem hiding this comment.
why do we need to mock this?
There was a problem hiding this comment.
Good Point. After replaying, this is useless.
| return total_metrics | ||
|
|
||
|
|
||
| def mock_toolresolver_resolve_tool_by_node(recording_file: Path): |
There was a problem hiding this comment.
add docstirng for why we need these fucntions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
Recording functionalities
Generated recording files will save in test_config/node_recordings folder
Some tricks
Time estimation
166 Tests run in 3min51s, total 226 tests estimate 5min18s
Most of the time is from fetching URLs.
About techniques of copying method and inject:
Currently I didn't get good ways to reuse the original method and make some patches to the method. All these mocked functions are copied and changed separately.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines