Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support image in batch run #785

Merged
merged 106 commits into from
Oct 27, 2023
Merged

Support image in batch run #785

merged 106 commits into from
Oct 27, 2023

Conversation

PeiwenGaoMS
Copy link
Contributor

@PeiwenGaoMS PeiwenGaoMS commented Oct 16, 2023 •
edited
Loading

Description

Support image in batch run

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@PeiwenGaoMS PeiwenGaoMS requested a review from a team as a code owner October 16, 2023 09:07
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 16, 2023 09:07 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 16, 2023 09:07 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 16, 2023 09:07 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 16, 2023 09:07 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 16, 2023 09:07 — with GitHub Actions Inactive
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Oct 16, 2023
@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

SDK CLI Global Config Test Result peiwen/supprt_image_in_batch_run

2 tests   2 ✔️  50s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 574116d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

Executor Unit Test Result peiwen/supprt_image_in_batch_run

377 tests   376 ✔️  48s ⏱️
    1 suites      1 💤
    1 files        0 ❌

Results for commit 574116d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

SDK PFS E2E Test Result peiwen/supprt_image_in_batch_run

8 tests   8 ✔️  31s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 574116d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

SDK CLI Test Result peiwen/supprt_image_in_batch_run

315 tests   302 ✔️  18m 3s ⏱️
    1 suites    13 💤
    1 files        0 ❌

Results for commit 574116d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

Executor E2E Test Result peiwen/supprt_image_in_batch_run

123 tests   121 ✔️  3m 5s ⏱️
    1 suites      2 💤
    1 files        0 ❌

Results for commit 574116d.

♻️ This comment has been updated with latest results.

@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 16, 2023 10:44 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 16, 2023 10:44 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 16, 2023 10:44 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 16, 2023 10:44 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 16, 2023 10:44 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 16, 2023 12:59 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 10:26 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 10:26 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 10:26 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 10:26 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 10:26 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 10:38 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 10:51 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 10:51 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 10:51 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 10:51 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 10:51 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 13:19 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 13:19 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 13:19 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 13:19 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 26, 2023 13:19 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 27, 2023 04:28 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 27, 2023 04:28 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 27, 2023 04:28 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 27, 2023 04:28 — with GitHub Actions Inactive
@PeiwenGaoMS PeiwenGaoMS temporarily deployed to internal October 27, 2023 04:28 — with GitHub Actions Inactive
@thy09 thy09 added the executor The changes related to the execution of the flow label Oct 27, 2023
@thy09 thy09 merged commit 97424e9 into main Oct 27, 2023
32 checks passed
@thy09 thy09 deleted the peiwen/supprt_image_in_batch_run branch October 27, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengfeiwang zhengfeiwang zhengfeiwang left review comments

@guming-learning guming-learning guming-learning left review comments

@thy09 thy09 thy09 approved these changes

@weedqian weedqian weedqian approved these changes

@RealKai42 RealKai42 RealKai42 left review comments

@D-W- D-W- D-W- left review comments

Assignees
No one assigned
Labels
executor The changes related to the execution of the flow promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@PeiwenGaoMS @weedqian @thy09 @D-W- @guming-learning @zhengfeiwang @RealKai42 @GPW9795