Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support list type flow input with image data #786

Merged
merged 37 commits into from
Oct 23, 2023
Merged

Support list type flow input with image data #786

merged 37 commits into from
Oct 23, 2023

Conversation

YingChen1996
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@YingChen1996 YingChen1996 requested a review from a team as a code owner October 16, 2023 09:49
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:49 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:49 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:49 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:49 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:49 — with GitHub Actions Inactive
@github-actions github-actions bot added sdk prompt flow SDK cli prompt flow CLI promptflow labels Oct 16, 2023
@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

SDK CLI Global Config Test Result chenyin/suport_multimedia_input

2 tests   2 ✔️  44s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 71a3516.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

Executor Unit Test Result chenyin/suport_multimedia_input

    2 files      2 suites   1m 59s ⏱️
385 tests 385 ✔️ 0 💤 0 ❌
748 runs  747 ✔️ 1 💤 0 ❌

Results for commit 71a3516.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

SDK PFS E2E Test Result chenyin/suport_multimedia_input

8 tests   8 ✔️  33s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 71a3516.

♻️ This comment has been updated with latest results.

@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:56 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:56 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:56 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:56 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:56 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:57 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:57 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:57 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:57 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:57 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:58 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:58 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:58 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 16, 2023 09:58 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 06:30 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 06:30 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 06:30 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 06:30 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 06:30 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 20, 2023 08:28 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 20, 2023 08:28 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 20, 2023 08:28 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 20, 2023 08:28 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 temporarily deployed to internal October 20, 2023 08:28 — with GitHub Actions Inactive
@brynn-code
Fix func
71a3516 
Signed-off-by: Brynn Yin <[email protected]>
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:35 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:35 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:35 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:35 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:35 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 09:05 — with GitHub Actions Inactive
@YingChen1996 YingChen1996 merged commit 42be774 into main Oct 23, 2023
31 checks passed
@YingChen1996 YingChen1996 deleted the chenyin/suport_multimedia_input branch October 23, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brynn-code brynn-code brynn-code approved these changes

@lalala123123 lalala123123 lalala123123 approved these changes

Assignees
No one assigned
Labels
cli prompt flow CLI promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YingChen1996 @lalala123123 @brynn-code