Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Samples]Add column mapping in CLI sample #813

Merged
merged 8 commits into from
Oct 24, 2023
Merged

[Samples]Add column mapping in CLI sample #813

merged 8 commits into from
Oct 24, 2023

Conversation

D-W-
Copy link
Contributor

@D-W- D-W- commented Oct 18, 2023

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

Add column mapping in CLI sample and link to column mapping behavior doc to avoid user confusing on it's default behavior.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@D-W- D-W- requested a review from a team as a code owner October 18, 2023 09:42
@D-W- D-W- temporarily deployed to internal October 18, 2023 09:42 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 18, 2023 09:42 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 18, 2023 09:42 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 18, 2023 09:42 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 18, 2023 09:42 — with GitHub Actions Inactive
@github-actions github-actions bot added documentation Improvements or additions to documentation examples Improvements on examples promptflow labels Oct 18, 2023
@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

SDK CLI Global Config Test Result wanhan/add_column_mapping

2 tests   2 ✔️  42s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 872ef17.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

Executor Unit Test Result wanhan/add_column_mapping

    2 files      2 suites   2m 16s ⏱️
385 tests 385 ✔️ 0 💤 0 ❌
748 runs  747 ✔️ 1 💤 0 ❌

Results for commit 872ef17.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

SDK PFS E2E Test Result wanhan/add_column_mapping

8 tests   8 ✔️  34s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 872ef17.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

Executor E2E Test Result wanhan/add_column_mapping

    2 files      2 suites   7m 36s ⏱️
104 tests 102 ✔️ 2 💤 0 ❌
208 runs  202 ✔️ 6 💤 0 ❌

Results for commit 872ef17.

♻️ This comment has been updated with latest results.

@0mza987
Copy link
Contributor

0mza987 commented Oct 18, 2023

Several CI failed

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

SDK CLI Test Result wanhan/add_column_mapping

    2 files      2 suites   24m 13s ⏱️
305 tests 292 ✔️ 13 💤 0 ❌
610 runs  584 ✔️ 26 💤 0 ❌

Results for commit 872ef17.

♻️ This comment has been updated with latest results.

0mza987
0mza987 previously approved these changes Oct 19, 2023
View reviewed changes
@D-W- D-W- temporarily deployed to internal October 19, 2023 06:15 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 19, 2023 06:15 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 19, 2023 06:15 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 19, 2023 06:15 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 19, 2023 06:15 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 20, 2023 06:52 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 20, 2023 06:52 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 20, 2023 06:52 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 20, 2023 06:52 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 20, 2023 06:52 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 20, 2023 06:58 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 20, 2023 06:58 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 20, 2023 06:58 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 20, 2023 06:58 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 20, 2023 06:58 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 04:05 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 04:05 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 04:05 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 04:05 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 04:05 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 06:41 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 06:41 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 06:41 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 06:41 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 06:41 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 08:34 — with GitHub Actions Inactive
@D-W- D-W- temporarily deployed to internal October 23, 2023 08:35 — with GitHub Actions Inactive
@D-W- D-W- merged commit 6aafcf5 into main Oct 24, 2023
56 checks passed
@D-W- D-W- deleted the wanhan/add_column_mapping branch October 24, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

@0mza987 0mza987 0mza987 left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples Improvements on examples promptflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D-W- @0mza987 @zhengfeiwang @wangchao1230