Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine for mlflow flavor support #816

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Refine for mlflow flavor support #816

merged 6 commits into from
Oct 23, 2023

Conversation

brynn-code
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@brynn-code brynn-code requested a review from a team as a code owner October 18, 2023 11:54
@brynn-code brynn-code temporarily deployed to internal October 18, 2023 11:54 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 18, 2023 11:54 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 18, 2023 11:54 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 18, 2023 11:54 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 18, 2023 11:54 — with GitHub Actions Inactive
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Oct 18, 2023
@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

SDK CLI Global Config Test Result brynn/refine-for-mlflow-flavor

2 tests   2 ✔️  42s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit b2de682.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

Executor Unit Test Result brynn/refine-for-mlflow-flavor

    2 files      2 suites   1m 41s ⏱️
385 tests 385 ✔️ 0 💤 0 ❌
748 runs  747 ✔️ 1 💤 0 ❌

Results for commit b2de682.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

SDK PFS E2E Test Result brynn/refine-for-mlflow-flavor

8 tests   8 ✔️  22s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit b2de682.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

Executor E2E Test Result brynn/refine-for-mlflow-flavor

    2 files      2 suites   10m 12s ⏱️
104 tests 102 ✔️ 2 💤 0 ❌
208 runs  202 ✔️ 6 💤 0 ❌

Results for commit b2de682.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

SDK CLI Test Result brynn/refine-for-mlflow-flavor

    2 files      2 suites   30m 6s ⏱️
305 tests 292 ✔️ 13 💤 0 ❌
610 runs  584 ✔️ 26 💤 0 ❌

Results for commit b2de682.

♻️ This comment has been updated with latest results.

@brynn-code brynn-code temporarily deployed to internal October 20, 2023 06:53 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 06:53 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 06:53 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 06:53 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 06:53 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 07:57 — with GitHub Actions Inactive
@brynn-code
Refine annotation
fcd65d6 
Signed-off-by: Brynn Yin <[email protected]>
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:17 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:17 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:17 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:17 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 20, 2023 08:17 — with GitHub Actions Inactive
0mza987
0mza987 previously approved these changes Oct 20, 2023
View reviewed changes
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 03:28 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 03:28 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 03:28 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 03:28 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 03:28 — with GitHub Actions Inactive
@brynn-code
Update doc
b246b0b 
Signed-off-by: Brynn Yin <[email protected]>
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 03:32 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 03:32 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 03:32 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 03:32 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 03:32 — with GitHub Actions Inactive
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 23, 2023
@brynn-code
Refine
b2de682 
Signed-off-by: Brynn Yin <[email protected]>
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 04:05 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 04:05 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 04:05 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 04:05 — with GitHub Actions Inactive
@brynn-code brynn-code temporarily deployed to internal October 23, 2023 04:05 — with GitHub Actions Inactive
@github-actions github-actions bot added the cli prompt flow CLI label Oct 23, 2023
@brynn-code brynn-code merged commit 14a49a0 into main Oct 23, 2023
31 checks passed
@brynn-code brynn-code deleted the brynn/refine-for-mlflow-flavor branch October 23, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@zhengfeiwang zhengfeiwang zhengfeiwang approved these changes

@YingChen1996 YingChen1996 YingChen1996 approved these changes

@0mza987 0mza987 0mza987 left review comments

Assignees
No one assigned
Labels
cli prompt flow CLI documentation Improvements or additions to documentation promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brynn-code @0mza987 @YingChen1996 @zhengfeiwang @wangchao1230