Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema link for custom strong type connection #835

Merged
merged 11 commits into from
Oct 23, 2023
Merged

Add schema link for custom strong type connection #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
125f0de
add schema
Oct 20, 2023
f94e636
Merge branch 'main' into chesi/add-schema-url-for-strong-type
chenslucky Oct 20, 2023
ef9de8c
fix uts
Oct 20, 2023
2513676
Merge branch 'main' into chesi/add-schema-url-for-strong-type
chenslucky Oct 20, 2023
05d9088
fix tests
Oct 20, 2023
b6e24e5
Merge branch 'chesi/add-schema-url-for-strong-type' of https://github…
Oct 20, 2023
da96c1d
Merge branch 'main' into chesi/add-schema-url-for-strong-type
chenslucky Oct 23, 2023
6004aa4
fix schema
Oct 23, 2023
76610f2
fix schema
Oct 23, 2023
c7db086
fix uts
Oct 23, 2023
ac3d1f6
fix uts
Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/promptflow/promptflow/_utils/connection_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ def generate_custom_strong_type_connection_spec(cls, package, package_version):

def generate_custom_strong_type_connection_template(cls, connection_spec, package, package_version):
connection_template_str = """
$schema: https://azuremlschemas.azureedge.net/promptflow/latest/CustomStrongTypeConnection.schema.json
name: "to_replace_with_connection_name"
type: custom
custom_type: {{ custom_type }}
Expand Down
4 changes: 2 additions & 2 deletions src/promptflow/tests/executor/unittests/_core/test_tools_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ def test_collect_package_tools_and_connections(self, install_custom_tool_pkg):
}

expected_template = {
"$schema": "https://azuremlschemas.azureedge.net/promptflow/latest/CustomStrongTypeConnection.schema.json",
chenslucky marked this conversation as resolved.
Show resolved Hide resolved
"name": "to_replace_with_connection_name",
"type": "custom",
"custom_type": "MyFirstConnection",
Expand Down Expand Up @@ -197,5 +198,4 @@ def test_collect_package_tools_and_connections(self, install_custom_tool_pkg):

content = templates["my_tool_package.tools.my_tool_with_custom_strong_type_connection.MyCustomConnection"]
expected_template_str = textwrap.dedent(expected_template)

assert content in expected_template_str
assert expected_template_str in content
Loading