Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support images in complicated structure as node input #837

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Support images in complicated structure as node input #837

merged 2 commits into from
Oct 20, 2023

Conversation

lumoslnt
Copy link
Contributor

@lumoslnt lumoslnt commented Oct 20, 2023 •
edited
Loading

Description

We only support single image as node input before, in this PR, we support images in complicated structure as node input.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@lumoslnt lumoslnt requested a review from a team as a code owner October 20, 2023 08:44
@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 08:44 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 08:44 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 08:44 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 08:44 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 08:44 — with GitHub Actions Inactive
@lumoslnt lumoslnt changed the title Support images in node input Support images in complicated structures for node input Oct 20, 2023
@lumoslnt lumoslnt changed the title Support images in complicated structures for node input Support images in complicated structures as node input Oct 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

SDK CLI Global Config Test Result devs/linatang/support-images-in-node-input

2 tests   2 ✔️  50s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 21ebf7f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Executor Unit Test Result devs/linatang/support-images-in-node-input

    2 files      2 suites   1m 47s ⏱️
385 tests 385 ✔️ 0 💤 0 ❌
748 runs  747 ✔️ 1 💤 0 ❌

Results for commit 21ebf7f.

♻️ This comment has been updated with latest results.

@lumoslnt lumoslnt changed the title Support images in complicated structures as node input Support images in complicated structure as node input Oct 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

SDK PFS E2E Test Result devs/linatang/support-images-in-node-input

8 tests   8 ✔️  33s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 21ebf7f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Executor E2E Test Result devs/linatang/support-images-in-node-input

    2 files      2 suites   6m 41s ⏱️
104 tests 102 ✔️ 2 💤 0 ❌
208 runs  202 ✔️ 6 💤 0 ❌

Results for commit 21ebf7f.

♻️ This comment has been updated with latest results.

@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 09:00 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 09:00 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 09:00 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 09:00 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 09:00 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

SDK CLI Test Result devs/linatang/support-images-in-node-input

    2 files      2 suites   29m 20s ⏱️
306 tests 293 ✔️ 13 💤 0 ❌
612 runs  586 ✔️ 26 💤 0 ❌

Results for commit 21ebf7f.

♻️ This comment has been updated with latest results.

@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 10:32 — with GitHub Actions Inactive
@lumoslnt lumoslnt temporarily deployed to internal October 20, 2023 10:52 — with GitHub Actions Inactive
@lumoslnt lumoslnt merged commit cae6dfd into main Oct 20, 2023
31 checks passed
@lumoslnt lumoslnt deleted the devs/linatang/support-images-in-node-input branch October 20, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingrabbitt1 codingrabbitt1 codingrabbitt1 approved these changes

@thy09 thy09 thy09 approved these changes

Assignees
No one assigned
Labels
promptflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumoslnt @thy09 @codingrabbitt1