Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pf tool] Support tool init with advance info, such as icon, tags and category #838

Merged
merged 10 commits into from
Oct 24, 2023

Conversation

lalala123123
Copy link
Contributor

@lalala123123 lalala123123 commented Oct 20, 2023

Description

70e65be
Support tool init with advance info, such as icon, tags and category

pf tool init --package package_tool --tool tool_name --set icon=<icon-path> category=<category> tags="{'key': 'value'}"

tool meta:

"test_cli_package.cli_tool.cli_tool": {
    "name": "cli_tool",
    "type": "python",
    "inputs": {
      "connection": {
        "type": [
          "CustomConnection"
        ]
      },
      "input_text": {
        "type": [
          "string"
        ]
      }
    },
    "description": "This is cli_tool tool",
    "module": "test_cli_package.cli_tool",
    "function": "cli_tool",
    "icon": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAIAAACQkWg2AAABcElEQVR4nJVSsUoDQRB9e+dd4p0xESHaHBEsJCEKsbf0C+z0B/wHv8PC3sIvEMFWRAJKFCwsDBpIyEbwyJlj9/bcHQtPiBgMmfLx3sybmceICLOUNRP7R0AErQ19EsxUAZtoiYgYYxMRC4B5fVLHRxcPh8/hZdbmN3scsQCYt256fnr7ctKN7lSSjuIoiqJxtjGm3++P7WBZcHKOPWc0Hu/bzWaz1+sppZRSWus0TUejUavViuMYwBwA2y/Mb9RXl1aLXiDEhxCSc95ut6WUruuWSqXBYMA5r9frvu9bAG6WGzu7Z3tOqcEsAZYmUghRq9WCICgWi0mSVCqVarVaLpczS2FirvtKvV9BvOa8Rd/ztNadTkdKGcfxcDjknGutwzDMLBkABJgUMNuba9ArKjVSSt/3oyjK5/NE5LqubduZIPDY/rrjLhxgYcvLO4Dj/dynUChMfxzR98Q/P2YsExBgCDY0GJuarsnR+KdmTusX7Qa9XJS8qLcAAAAASUVORK5CYII=",
    "category": "test_category",
    "tags": {
      "key": "value"
    },
    "package": "test-cli-package",
    "package_version": "0.0.1"
  }
}

Folder structure

TOOL_WITH_EXTRA_INFO
│   MANIFEST.in
│   README.md
│   setup.py
│
├───icon
│       logo.jpg
│
└───tool_with_extra_info
        func_name.py
        utils.py
        __init__.py

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@lalala123123 lalala123123 temporarily deployed to internal October 20, 2023 09:31 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 20, 2023 09:31 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 20, 2023 09:31 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 20, 2023 09:31 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 20, 2023 09:31 — with GitHub Actions Inactive
@lalala123123 lalala123123 marked this pull request as ready for review October 20, 2023 09:31
@lalala123123 lalala123123 requested a review from a team as a code owner October 20, 2023 09:31
@github-actions github-actions bot added examples Improvements on examples sdk prompt flow SDK cli prompt flow CLI promptflow labels Oct 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 20, 2023

SDK CLI Global Config Test Result zhrua/tool_support_advance_feature

2 tests   2 ✔️  53s ⏱️
1 suites  0 💤
1 files    0

Results for commit a2d660d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Executor Unit Test Result zhrua/tool_support_advance_feature

    2 files      2 suites   2m 0s ⏱️
386 tests 385 ✔️ 1 💤 0
750 runs  747 ✔️ 3 💤 0

Results for commit a2d660d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

SDK PFS E2E Test Result zhrua/tool_support_advance_feature

8 tests   8 ✔️  28s ⏱️
1 suites  0 💤
1 files    0

Results for commit a2d660d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Executor E2E Test Result zhrua/tool_support_advance_feature

    2 files      2 suites   6m 10s ⏱️
108 tests 106 ✔️ 2 💤 0
216 runs  210 ✔️ 6 💤 0

Results for commit a2d660d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

SDK CLI Test Result zhrua/tool_support_advance_feature

    2 files      2 suites   24m 42s ⏱️
305 tests 292 ✔️ 13 💤 0
610 runs  584 ✔️ 26 💤 0

Results for commit a2d660d.

♻️ This comment has been updated with latest results.

@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 02:16 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 02:16 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 02:16 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 02:16 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 02:16 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 02:41 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 02:41 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 02:41 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 02:41 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 02:41 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 08:01 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 08:01 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 08:01 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 08:01 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 08:01 — with GitHub Actions Inactive
@github-actions github-actions bot removed the examples Improvements on examples label Oct 23, 2023
zhengfeiwang
zhengfeiwang previously approved these changes Oct 23, 2023
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 08:15 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 11:53 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 23, 2023 11:54 — with GitHub Actions Inactive
wangchao1230
wangchao1230 previously approved these changes Oct 24, 2023
@lalala123123 lalala123123 temporarily deployed to internal October 24, 2023 03:22 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 24, 2023 03:22 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 24, 2023 03:22 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 24, 2023 03:22 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 24, 2023 03:22 — with GitHub Actions Inactive
@lalala123123 lalala123123 temporarily deployed to internal October 24, 2023 04:50 — with GitHub Actions Inactive
@lalala123123 lalala123123 merged commit 50a164e into main Oct 24, 2023
31 checks passed
@lalala123123 lalala123123 deleted the zhrua/tool_support_advance_feature branch October 24, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli prompt flow CLI promptflow sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants