Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editable scope in PYTHONPATH in dev_setup guide #844

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix editable scope in PYTHONPATH in dev_setup guide #844

merged 1 commit into from
Oct 23, 2023

Conversation

guming-learning
Copy link
Contributor

@guming-learning guming-learning commented Oct 22, 2023 •
edited
Loading

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@guming-learning guming-learning requested a review from a team as a code owner October 22, 2023 08:24
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 22, 2023
@guming-learning guming-learning merged commit a589f82 into main Oct 23, 2023
8 checks passed
@guming-learning guming-learning deleted the migu/update-dev-setup branch October 23, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chjinche chjinche chjinche approved these changes

@thy09 thy09 thy09 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guming-learning @thy09 @chjinche