-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[promptflow][BugFix] Not clean-up log file for batch run #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalala123123
previously approved these changes
Oct 23, 2023
huaiyan
previously approved these changes
Oct 23, 2023
zhengfeiwang
dismissed stale reviews from huaiyan and lalala123123
via
October 25, 2023 05:41
9e0d75c
Release Test Matrix 20 files - 4 20 suites - 4 3h 19m 16s ⏱️ - 1h 41m 12s For more details on these failures and errors, see this check. Results for commit 0437471. ± Comparison against base commit 2891054. This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.
|
YingChen1996
previously approved these changes
Oct 25, 2023
brynn-code
approved these changes
Oct 25, 2023
YingChen1996
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous PR #235 adds clean up log file logic, which will remove some system logs printed by executor. This PR adds a check first, and will not clean up for batch run, so that system/executor logs can be reserved.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines