Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[promptflow][BugFix] Not clean-up log file for batch run #851

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Oct 23, 2023

Description

Previous PR #235 adds clean up log file logic, which will remove some system logs printed by executor. This PR adds a check first, and will not clean up for batch run, so that system/executor logs can be reserved.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zhengfeiwang zhengfeiwang requested a review from a team as a code owner October 23, 2023 07:38
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 23, 2023 07:38 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 23, 2023 07:38 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 23, 2023 07:38 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 23, 2023 07:38 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 23, 2023 07:38 — with GitHub Actions Inactive
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Oct 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

SDK CLI Global Config Test Result zhengfei/bugfix/run-log-missing

2 tests   2 ✔️  47s ⏱️
1 suites  0 💤
1 files    0

Results for commit 148740c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

SDK PFS E2E Test Result zhengfei/bugfix/run-log-missing

8 tests   8 ✔️  33s ⏱️
1 suites  0 💤
1 files    0

Results for commit 148740c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Executor Unit Test Result zhengfei/bugfix/run-log-missing

    2 files      2 suites   1m 58s ⏱️
392 tests 391 ✔️ 1 💤 0
762 runs  759 ✔️ 3 💤 0

Results for commit 148740c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Executor E2E Test Result zhengfei/bugfix/run-log-missing

    2 files      2 suites   7m 34s ⏱️
120 tests 118 ✔️ 2 💤 0
240 runs  234 ✔️ 6 💤 0

Results for commit 148740c.

♻️ This comment has been updated with latest results.

lalala123123
lalala123123 previously approved these changes Oct 23, 2023
huaiyan
huaiyan previously approved these changes Oct 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

SDK CLI Test Result zhengfei/bugfix/run-log-missing

    2 files      2 suites   30m 16s ⏱️
308 tests 295 ✔️ 13 💤 0
616 runs  590 ✔️ 26 💤 0

Results for commit 148740c.

♻️ This comment has been updated with latest results.

@zhengfeiwang zhengfeiwang temporarily deployed to internal October 23, 2023 08:09 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 23, 2023 08:58 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 23, 2023 09:20 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 23, 2023 11:24 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 24, 2023 04:01 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 05:23 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang dismissed stale reviews from huaiyan and lalala123123 via 9e0d75c October 25, 2023 05:41
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 05:41 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 05:41 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 05:41 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 05:41 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 05:41 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 07:35 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 07:35 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 07:35 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 07:35 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 07:35 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 07:41 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 07:41 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 07:41 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 07:41 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 07:41 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 08:08 — with GitHub Actions Inactive
@github-actions
Copy link

Release Test Matrix

     20 files   -        4       20 suites   - 4   3h 19m 16s ⏱️ - 1h 41m 12s
   823 tests  -        1     771 ✔️ ±       0    16 💤 ±  0    34  -   1    2 🔥 ±0 
8 344 runs   - 1 218  8 070 ✔️  - 1 174  156 💤  - 52  104 +10  14 🔥  - 2 

For more details on these failures and errors, see this check.

Results for commit 0437471. ± Comparison against base commit 2891054.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.
tests.sdk_cli_test.unittests.test_run.TestRun ‑ test_invalid_yaml[tests\\test_configs\\runs/illegal/extra_field.yaml-Unknown field]
tests.sdk_cli_test.unittests.test_run.TestRun ‑ test_invalid_yaml[tests\\test_configs\\runs/illegal/non_exist_data.yaml-Can't find directory or file]
tests.sdk_cli_test.e2etests.test_flow_run.TestFlowRun ‑ test_executor_logs_in_batch_run_logs

YingChen1996
YingChen1996 previously approved these changes Oct 25, 2023
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 08:38 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 08:38 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 08:38 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 08:38 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang temporarily deployed to internal October 25, 2023 08:38 — with GitHub Actions Inactive
@zhengfeiwang zhengfeiwang merged commit d0486dd into main Oct 25, 2023
31 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/bugfix/run-log-missing branch October 25, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
promptflow sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants